Skip to content

Conversation

@MichalStrehovsky
Copy link
Member

The fix presumably merged in #121941.

Cc @dotnet/ilc-contrib

The fix presumably merged in #121941.
Copilot AI review requested due to automatic review settings November 25, 2025 22:27
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 25, 2025
@MichalStrehovsky
Copy link
Member Author

/azp run runtime-nativeaot-outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copilot finished reviewing on behalf of MichalStrehovsky November 25, 2025 22:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables async testing for NativeAOT on x86 architecture by removing a build exclusion that was previously in place due to issue #121872. The fix referenced in issue #121941 has presumably resolved the underlying problem.

Key Changes

  • Removed the DisableProjectBuild condition that prevented async tests from building for NativeAOT on x86 architecture
  • Maintained the existing exclusion for arm64 architecture (issue #121878 remains unresolved)

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@MichalStrehovsky MichalStrehovsky added area-NativeAOT-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 25, 2025
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@MichalStrehovsky
Copy link
Member Author

/ba-g all failures due to macos brownout

@MichalStrehovsky MichalStrehovsky merged commit d23cb67 into main Nov 26, 2025
91 of 103 checks passed
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-2 branch November 26, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants