[clr-interp] Fix GitHub_9651 by allowing an I4 to be treated as a ByRef #122189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
davidwrighton
commented
Dec 4, 2025
davidwrighton
commented
- This is part of allowing I4 and I to be interchangeable, since some forms of ByRef will devolve to be treated as an I
- This isn't a fully general purpose fix, but in cases where it is valid code it will make it work.
- This is part of allowing I4 and I to be interchangeable, since some forms of ByRef will devolve to be treated as an I - This isn't a fully general purpose fix, but in cases where it is valid code it will make it work.
davidwrighton
changed the title
github-actions
bot
added
the
needs-area-label
davidwrighton
removed
the
needs-area-label
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes GitHub issue #9651 in the CoreCLR interpreter by allowing I4 (int32) values to be implicitly converted to ByRef types on 64-bit systems. The fix addresses a specific scenario where I4 and native int/ByRef can be used interchangeably in valid IL code, particularly when branching logic may assign either an int32 or an address to a native int variable.
Key Changes
- Modified the type conversion logic in the interpreter compiler to treat I4 to ByRef conversions similar to I4 to I8 (nint) conversions on 64-bit targets
- This allows IL code patterns where int32 zero and addresses are used interchangeably with native int variables
BrzVlad
approved these changes
Dec 4, 2025
This was referenced Dec 4, 2025
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.