Restore SuppressGCTransition handling#122904
Merged
jkoritzinsky merged 1 commit intodotnet:mainfrom Jan 6, 2026
Merged
Conversation
jkotas
approved these changes
Jan 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where SuppressGCTransitionAttribute was not being applied to PInvoke methods that have an explicit unmanaged calling convention set via metadata flags (e.g., Cdecl, StdCall, ThisCall). The fix moves the attribute check from inside a conditional block (where it only executed for EcmaMethod instances) to after the entire conditional structure, ensuring it applies to all PInvoke methods regardless of how their calling convention is determined.
Key Changes
- Moved
SuppressGCTransitionAttributecheck outside theelse if (method is EcmaMethod ecmaMethod)block - The attribute is now checked unconditionally for all PInvoke methods, not just those without explicit calling convention metadata
Member
|
/ba-g deadletter |
This was referenced Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #122762