Skip to content

Remove GetFullName(DefType) extension method and replace usage #123001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichalStrehovsky merged 3 commits into from
Jan 9, 2026
+1 −10
Merged

Remove GetFullName(DefType) extension method and replace usage #123001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
274b284
Initial plan
Copilot Jan 8, 2026
4e0c397
Remove GetFullName(DefType) extension method and replace usages
Copilot Jan 8, 2026
a99abf8
Update src/coreclr/tools/Common/TypeSystem/Common/TypeSystemHelpers.cs
jkotas Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/coreclr/tools/Common/TypeSystem/Common/TypeSystemHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,15 +157,6 @@ public static MethodDesc FindMethodOnTypeWithMatchingTypicalMethod(this TypeDesc
return null;
}

/// <summary>
/// Retrieves the namespace qualified name of a <see cref="DefType"/>.
/// </summary>
public static ReadOnlySpan<byte> GetFullName(this DefType metadataType)
{
ReadOnlySpan<byte> ns = metadataType.Namespace;
return ns.Length > 0 ? ns.Append("."u8, metadataType.Name) : metadataType.Name;
}

/// <summary>
/// Retrieves all methods on a type, including the ones injected by the type system context.
/// </summary>
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/tools/Common/TypeSystem/Ecma/EcmaType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ public override MethodDesc GetFinalizer()
if (impl == null)
{
// TODO: invalid input: the type doesn't derive from our System.Object
throw new TypeLoadException(System.Text.Encoding.UTF8.GetString(this.GetFullName()));
ThrowHelper.ThrowTypeLoadException(this);
}

if (impl.OwningType != objectType)
Expand Down
Loading