-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Update NativeAOT Docker samples to use .NET 10 images #123241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
|
@copilot Also update https://github.com/dotnet/runtime/blob/main/src/coreclr/nativeaot/docs/containers.md to refer to Ubuntu 18.04 as the oldest compatible version for .NET 10 |
…ersion for .NET 10 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
Updated in cdccdc0. Changed Ubuntu 16.04 references to Ubuntu 18.04 in both the description and the example command. |
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the NativeAOT Docker sample documentation to use .NET 10 container images, modernizing from the older .NET 8/CBL Mariner 2.0 images to .NET 10/Azure Linux 3.0 images.
Changes:
- Updated base container images from CBL Mariner 2.0 to Azure Linux 3.0 with .NET 10 support
- Updated SDK images from .NET 8 to .NET 10
- Removed the manual symlink creation for the dotnet command (line 3 in both Dockerfiles)
- Corrected Ubuntu compatibility from 16.04 to 18.04 for .NET 10
- Fixed broken hyperlink for x64-x64 Dockerfile
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Dockerfile.cross-build-x64-x64 | Updated from CBL Mariner 2.0/.NET 8 to Azure Linux 3.0/.NET 10 images and removed manual dotnet symlink |
| Dockerfile.cross-build-x64-arm64 | Updated from CBL Mariner 2.0/.NET 8 to Azure Linux 3.0/.NET 10 images and removed manual dotnet symlink |
| containers.md | Updated Ubuntu compatibility to 18.04, fixed broken Dockerfile link, updated example commands to use ubuntu:18.04 |
MichalStrehovsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Description
Updates Docker sample files in NativeAOT documentation from .NET 8 to .NET 10 images, aligning with the machine images documented in
docs/workflow/using-docker.mdon the release/10.0 branch.Changes
Dockerfile.cross-build-x64-arm64:
cbl-mariner-2.0-cross-arm64→azurelinux-3.0-net10.0-cross-arm64dotnet/sdk:8.0-cbl-mariner2.0-amd64→dotnet/sdk:10.0Dockerfile.cross-build-x64-x64:
cbl-mariner-2.0-cross-amd64→azurelinux-3.0-net10.0-cross-amd64dotnet/sdk:8.0-cbl-mariner2.0-amd64→dotnet/sdk:10.0containers.md:
ubuntu:18.04instead ofubuntu:16.04Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.