[browser] Check unique relative path for assemblies #123341
Merged
+207
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed duplicate file name check for asset candidates.
maraf
added
arch-wasm
maraf
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression in the WebAssembly build process where satellite assemblies from NuGet packages containing multiple cultures were incorrectly flagged as duplicate files. The fix ensures that satellite assemblies, which are deployed to culture-specific subdirectories, bypass the unique filename check that only applies to assemblies in the main framework folder.
Changes:
- Modified
ComputeWasmBuildAssets.csto skip the unique filename check for satellite assemblies with culture metadata - Added comprehensive test coverage including a new French localization and a test specifically for package-sourced satellite assemblies
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/ComputeWasmBuildAssets.cs |
Adds early return for satellite assemblies to bypass unique filename validation |
src/mono/wasm/testassets/WasmBasicTestApp/ResourceLibrary/words.fr-FR.resx |
Adds French localization resource file for testing multiple satellite assemblies |
src/mono/wasm/testassets/WasmBasicTestApp/ResourceLibrary/ResourceLibrary.csproj |
Conditionally references Microsoft.CodeAnalysis.CSharp package to test satellite assemblies from packages |
src/mono/wasm/testassets/WasmBasicTestApp/ResourceLibrary/ResourceAccessor.cs |
Adds French culture test output |
src/mono/wasm/testassets/WasmBasicTestApp/App/SatelliteAssembliesTest.cs |
Updates test to load fr-FR satellite assembly |
src/mono/wasm/Wasm.Build.Tests/SatelliteLoadingTests.cs |
Updates existing tests for French locale and adds new test for package-sourced satellite assemblies |
Member
Author
The |
ilonatommy
approved these changes
Jan 21, 2026
maraf
changed the title
javiercn
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change unique name check in
ComputeWasmBuildAssetsfrom file name to computed relative path in wwwroot. Satellite assemblies go each to a sub folder based on culture.Extend tests to verify behavior for referenced project and PackageReference with multiple satellite assemblies.
Fixes #123305