[main] Source code updates from dotnet/dotnet#123386
Conversation
[[ commit created by automation ]]
|
Important While this PR was open, the source repository has received code changes from this repository (an opposite codeflow merged). You can continue with one of the following options:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
|
@kotlarmilos please take a look at the swift errors |
|
@maraf lots of this on the wasm side |
|
@pavelsavara @maraf I assume this is related to #122495 now that the sdk has made it back |
I hope the missing nuget would be created here dotnet/dotnet#4326 |
|
WBT should default to Mono, not CoreCLR. AppSettingsTests should not run on CoreCLR |
|
@rolfbjarne would you know what's up with the Swift errors, it sounds similar to something I've seen recently, but I can't remember (or find it). |
I haven't seen these errors before, so I don't have any idea what might be going on. |
|
Just posting an update on what I found, maybe it can help someone find the real root cause of the failure: I've been looking at the logs and it looks like it's using
which causes the internal This causes -ld_classic flag (+ there are a bunch of other places which do a similar check and add the flag). I tried local build with added -ld_classic and got a green build.
Note, the same |
|
I've pulled down the binlog from the artifacts - yep, we're not passing The failure is actually not from the clang/lld invocation. The failure comes from the subsequent: I think the important part is I think we're somehow ending up compiling the static libraries that native AOT ships with this |
|
Here is what Sentry did to fix this: getsentry/sentry-cocoa#3800 if that helps. |
This is probably because this code assumes runtime/src/tasks/Crossgen2Tasks/Microsoft.NET.CrossGen.targets Lines 623 to 626 in fc7d401 which is very much not the case: $ clang --version
Apple clang version 17.0.0 (clang-1700.6.3.2)It looks like $ xcodebuild -version
Xcode 26.2
Build version 17C52 |
|
@rolfbjarne this was added in #100190 to replace calling xcodebuild and I think at the time the Xcode and clang versions aligned (but still differed from upstream clang), i.e. I still see clang --version reporting 16.0 for Xcode 16. It looks like clang didn't make the jump when Apple did the great version realigning to 26. |
|
I'm wondering if #120953 is the reason why we're seeing this? The failure is happening in If true, I think we're going to have to ignore the error (if possible) and publish a new package with correct build tweaks. |
|
I think that might be it. Not sure the best way to ignore / change anything because |
If we need a temporary unblock, I think setting StripSymbols property to false would work, since per the binlog this is from dsymutil/strip. Official builds might have a problem either the lack of dsym. Or we could use PublishSingleFile instead of PublishAot (this aasumes publishing cDAC doesn't run into this, since PublishSingleFile is not an option there). I don't have a mac and I'm OOF Monday/Tuesday so I'm not going to try these, just trying to help. |
|
I don’t think this is a runtime change, since we would otherwise be seeing it on main as well. I can reproduce the issue locally only on this PR, which suggests this is not an infra issue. I think I’ve identified a likely root cause in the SDK. First, there is a new property group for the default In the failing cases this resolves to osx-arm64 or osx-x64. Second, ILCompiler pack processing was changed to iterate over to As a result, ILCompiler packs are now processed for all RIDs in RuntimeIdentifiers, not only when EffectiveRuntimeIdentifier is set. I think for projects like When the runtime is build with |
|
I tried reverting the #120953 locally but the failure persisted. |
That's not surprising because the problem is in the consumption of a nuget. |
If we're not seeing it in main, that suggests we have been hiding the underlying issue. I think we need two changes. The first is either turning off strip symbols temporarily or setting I think that would prevent @rolfbjarne @akoeplinger thoughts? |
|
hmm we've been discussing dotnet/sdk#52565 and dotnet/sdk#52674 in the 11.0 preview chat since Viktor found that there was an issue when rebootstrapping the VMR, maybe it's related |
…gen2_publish to avoid failing the build looking for cached pcm files
|
/ba-g Known issue not picked up by BA #123918 |
| </ItemGroup> | ||
|
|
||
| <Exec Command="clang --version" Condition="'$(_IsApplePlatform)' == 'true' and '$(UseLdClassicXCodeLinker)' == ''" IgnoreExitCode="true" StandardOutputImportance="Low" ConsoleToMSBuild="true"> | ||
| <Exec Command="xcodebuild -version" Condition="'$(_IsApplePlatform)' == 'true' and '$(UseLdClassicXCodeLinker)' == ''" IgnoreExitCode="true" StandardOutputImportance="Low" ConsoleToMSBuild="true"> |
There was a problem hiding this comment.
@steveisok are we fine with keeping this change? it got changed a while ago because xcodebuild doesn't work when you only have the CommandLineTools package instead of full Xcode: #100189
> [!NOTE] > This is a codeflow update. It may contain both source code changes from > [the VMR](https://github.com/dotnet/dotnet) > as well as dependency updates. Learn more [here](https://github.com/dotnet/dotnet/tree/main/docs/Codeflow-PRs.md). This pull request brings the following source code changes [marker]: <> (Begin:f7901f87-9f24-40d6-9bc1-564863937237) ## From https://github.com/dotnet/dotnet - **Subscription**: [f7901f87-9f24-40d6-9bc1-564863937237](https://maestro.dot.net/subscriptions?search=f7901f87-9f24-40d6-9bc1-564863937237) - **Build**: [20260119.3](https://dev.azure.com/dnceng/internal/_build/results?buildId=2882688) ([297900](https://maestro.dot.net/channel/8298/github:dotnet:dotnet/build/297900)) - **Date Produced**: January 19, 2026 7:04:17 PM UTC - **Commit**: [adf42f5dcec99a409a6f63355f5b52147bfaf043](dotnet/dotnet@adf42f5) - **Commit Diff**: [bac6980...adf42f5](dotnet/dotnet@bac6980...adf42f5) - **Branch**: [main](https://github.com/dotnet/dotnet/tree/main) **Updated Dependencies** - From [5.4.0-2.26065.101 to 5.4.0-2.26069.103][1] - Microsoft.CodeAnalysis - Microsoft.CodeAnalysis.Analyzers - Microsoft.CodeAnalysis.CSharp - Microsoft.Net.Compilers.Toolset - From [11.0.100-alpha.1.26065.101 to 11.0.100-preview.1.26069.103][1] - Microsoft.CodeAnalysis.NetAnalyzers - Microsoft.DotNet.ApiCompat.Task - Microsoft.NET.Workload.Emscripten.Current.Manifest-11.0.100.Transport - From [11.0.0-beta.26065.101 to 11.0.0-beta.26069.103][1] - Microsoft.DotNet.Arcade.Sdk - Microsoft.DotNet.Build.Tasks.Archives - Microsoft.DotNet.Build.Tasks.Feed - Microsoft.DotNet.Build.Tasks.Installers - Microsoft.DotNet.Build.Tasks.Packaging - Microsoft.DotNet.Build.Tasks.TargetFramework - Microsoft.DotNet.Build.Tasks.Templating - Microsoft.DotNet.Build.Tasks.Workloads - Microsoft.DotNet.CodeAnalysis - Microsoft.DotNet.GenAPI - Microsoft.DotNet.GenFacades - Microsoft.DotNet.Helix.Sdk - Microsoft.DotNet.PackageTesting - Microsoft.DotNet.RemoteExecutor - Microsoft.DotNet.SharedFramework.Sdk - Microsoft.DotNet.XliffTasks - Microsoft.DotNet.XUnitExtensions - From [0.11.5-alpha.26065.101 to 0.11.5-preview.26069.103][1] - Microsoft.DotNet.Cecil - From [2.9.3-beta.26065.101 to 2.9.3-beta.26069.103][1] - Microsoft.DotNet.XUnitAssert - Microsoft.DotNet.XUnitConsoleRunner - From [11.0.0-alpha.1.26065.101 to 11.0.0-preview.1.26069.103][1] - Microsoft.NET.Sdk.IL - Microsoft.NETCore.App.Ref - Microsoft.NETCore.ILAsm - runtime.native.System.IO.Ports - System.Reflection.Metadata - System.Reflection.MetadataLoadContext - System.Text.Json - From [7.3.0-preview.1.6601 to 7.3.0-preview.1.7003][1] - NuGet.Frameworks - NuGet.Packaging - NuGet.ProjectModel - NuGet.Versioning - From [3.0.0-alpha.1.26065.101 to 3.0.0-preview.1.26069.103][1] - System.CommandLine - From [11.0.0-alpha.1.25628.1 to 11.0.0-alpha.1.26061.1](dotnet/dotnet@0f3a9cd...7a708d1) - runtime.linux-arm64.Microsoft.NETCore.Runtime.Wasm.Node.Transport - runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Wasm.Node.Transport - runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Wasm.Node.Transport - runtime.linux-x64.Microsoft.NETCore.Runtime.Wasm.Node.Transport - runtime.osx-arm64.Microsoft.NETCore.Runtime.Wasm.Node.Transport - runtime.osx-x64.Microsoft.NETCore.Runtime.Wasm.Node.Transport - runtime.win-arm64.Microsoft.NETCore.Runtime.Wasm.Node.Transport - runtime.win-x64.Microsoft.NETCore.Runtime.Wasm.Node.Transport [marker]: <> (End:f7901f87-9f24-40d6-9bc1-564863937237) [1]: dotnet/dotnet@bac6980...adf42f5 [marker]: <> (Start:Footer:CodeFlow PR) ## Associated changes in source repos - dotnet/aspnetcore@30d4d50...03d43ac - dotnet/efcore@d52eb38...af8a90c - dotnet/razor@3eb8321...0152051 - dotnet/roslyn@e6f840b...a8d1f35 - dotnet/runtime@d120108...6afecd4 - dotnet/sdk@ec5f7d9...73e74e8 - dotnet/sourcelink@8573980...a4a7b91 - dotnet/templating@dba5ef6...c5d5136 <details> <summary>Diff the source with this PR branch</summary> ```bash darc vmr diff --name-only https://github.com/dotnet/dotnet:adf42f5dcec99a409a6f63355f5b52147bfaf043..https://github.com/dotnet/runtime:darc-main-f7b01ba7-7db3-41b6-a678-1a49970ee930 ``` </details> [marker]: <> (End:Footer:CodeFlow PR) --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Larry Ewing <lewing@microsoft.com> Co-authored-by: Marek Fišera <mara@neptuo.com> Co-authored-by: Milos Kotlar <kotlarmilos@gmail.com> Co-authored-by: Steve Pfister <stpfiste@microsoft.com>
Note
This is a codeflow update. It may contain both source code changes from
the VMR
as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
Updated Dependencies
Associated changes in source repos
Diff the source with this PR branch