Use IndexOfAny in Console's TermInfo #123646
Merged
+3
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not a perf sensitive thing, just a bit simpler
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-console |
Contributor
There was a problem hiding this comment.
Pull request overview
Simplifies TermInfo printf-format parsing in System.Console by replacing a manual scan loop with IndexOfAny to locate the format terminator.
Changes:
- Replaced a
forloop scanning ford/o/x/X/swithformat.AsSpan(pos).IndexOfAny("doxXs"). - Adjusted the returned index to be absolute (
printfEnd += pos) and preserved existing error behavior when no terminator is found.
MihaZupan
approved these changes
Jan 27, 2026
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
This was referenced Jan 27, 2026
Open
Member
Author
|
/ba-g unrelated timeout |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a perf sensitive thing, just a bit simpler