Skip to content

Use IndexOfAny in Console's TermInfo #123646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 4 commits into from
Jan 30, 2026
+3 −11
Merged

Use IndexOfAny in Console's TermInfo #123646

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
244c960
Use IndexOfAny in Console's TermInfo
stephentoub Jan 26, 2026
8f390f7
Update src/libraries/System.Console/src/System/TermInfo.cs
stephentoub Jan 27, 2026
30b1df2
Merge branch 'main' into terminfoioa
stephentoub Jan 27, 2026
8b94e5f
Merge branch 'main' into terminfoioa
stephentoub Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions src/libraries/System.Console/src/System/TermInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,20 +161,12 @@ private static string EvaluateInternal(
// (with a ':' used in front of flags to help differentiate from binary operations, as flags can
// include '-' and '+'). While above we've special-cased common usage (e.g. %d, %s),
// for more complicated expressions we delegate to printf.
int printfEnd = pos;
for (; printfEnd < format.Length; printfEnd++) // find the end of the printf format string
{
char ec = format[printfEnd];
if (ec == 'd' || ec == 'o' || ec == 'x' || ec == 'X' || ec == 's')
{
break;
}
}
if (printfEnd >= format.Length)
int printfEnd = format.AsSpan(pos).IndexOfAny("doxXs"); // find the end of the printf format string
if (printfEnd < 0)
{
throw new InvalidOperationException(SR.IO_TermInfoInvalid);
}
string printfFormat = format.Substring(pos - 1, printfEnd - pos + 2); // extract the format string
string printfFormat = format.Substring(pos - 1, printfEnd + 2); // extract the format string
if (printfFormat.Length > 1 && printfFormat[1] == ':')
{
printfFormat = printfFormat.Remove(1, 1);
Expand Down
Loading