[NativeAOT] Do not overwrite throw frame with first rethrow frame

[rcj1]

Currently in NativeAOT, we overwrite the stack trace frame before a rethrow with the rethrow frame. This means that for the following code:

static void Test1()
{
    try
    {
        Test2();
    }
    catch (Exception ex)
    {
        throw;
    }
}

static async Task Test2()
{
    throw new Exception("This is a test exception from Y");
}

The exception stacktrace includes throw new Exception and throw, as opposed to throw new Exception and Test2(). This was spotted as a bug in #9518 and fixed in dotnet/coreclr#16464; the corresponding coreclr code is

runtime/src/coreclr/vm/exceptionhandling.cpp

Line 2992 in 59b270c

if ((flags & RH_EH_FIRST_RETHROW_FRAME) == 0)

. This PR is the equivalent bug fix for NativeAOT.

Fixes #107507?

[Copilot]

Pull request overview

This PR fixes a bug in NativeAOT where exception stack traces incorrectly showed the location of a throw; rethrow statement instead of the original throw location. The fix aligns NativeAOT's behavior with CoreCLR by skipping stack frame recording during rethrow operations, preserving the original throw location.

Changes:

• Modified AppendStackIP to remove the isFirstRethrowFrame parameter and the logic that overwrote stack frames during rethrows
• Updated AppendExceptionStackFrame to skip calling AppendStackIP entirely when isFirstRethrowFrame is true

[janvorli]

LGTM, thank you!

[SingleAccretion]

Fixes #107507?

[jkotas]

/azp run runtime-nativeaot-outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jkotas]

LGTM once runtime-nativeaot-outerloop shows no regressions related to this change.

[jkotas]

/ba-g infrastructure timeouts