Skip to content

Fix NativeAOT publish including satellite assemblies despite embedding them #124192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+1 −0
Draft

Fix NativeAOT publish including satellite assemblies despite embedding them #124192

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1bca05
Initial plan
Copilot Feb 9, 2026
1801e3b
Add fix to remove satellite assemblies from publish folder and create…
Copilot Feb 9, 2026
3feb4a7
Remove test from runtime repo per review feedback
Copilot Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
<ItemGroup>
<IntermediateAssembly Remove="@(IntermediateAssembly)" />
<IntermediateAssembly Include="$(NativeBinary)" />
<IntermediateSatelliteAssembliesWithTargetPath Remove="@(IntermediateSatelliteAssembliesWithTargetPath)" />
Copy link
Member

@MichalStrehovsky MichalStrehovsky Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot where is the logic that filters out satellite assemblies from NuGet references? I can see that we correctly don't preserve satellite assemblies from NuGet references. The issue is isolated to satellite assemblies from current assembly.

Copy link
Contributor Author

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic for filtering NuGet satellite assemblies is in the ComputeManagedAssembliesToCompileToNative task (lines 74-85), which outputs _AssembliesToSkipPublish. Line 25 then removes those from _ResolvedCopyLocalPublishAssets.

The fix in line 33 addresses the project's own satellite assemblies by removing IntermediateSatelliteAssembliesWithTargetPath, which the SDK would otherwise unconditionally add back to the publish list.

</ItemGroup>
</Target>

Expand Down
Loading