Skip to content

Remove --buildXUnitWrappers from runtest.cmd/runtest.sh #31798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2020
Merged

Remove --buildXUnitWrappers from runtest.cmd/runtest.sh #31798

merged 1 commit into from
Feb 25, 2020

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Feb 5, 2020

It looks unused, it forwards --build_xunit_test_wrappers to runtests.py which is not handled there (see https://github.com/dotnet/runtime/blob/master/src/coreclr/tests/runtest.py)

so buildxunitwrappers passed to build.sh/cmd simply fails with unknown parameter --build_xunit_test_wrappers in the python script.

@jashook jashook merged commit 489ffcd into dotnet:master Feb 25, 2020
@EgorBo EgorBo deleted the cleanup-runtest-py branch May 25, 2020 11:57
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jashook jashook jashook approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Infrastructure-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EgorBo @jashook @Dotnet-GitSync-Bot