Skip to content

Remove --buildXUnitWrappers from runtest.cmd/runtest.sh #31798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Remove --buildXUnitWrappers from runtest.cmd/runtest.sh #31798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/coreclr/tests/runtest.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ set __IlasmRoundTrip=
set __CollectDumps=
set __DoCrossgen=
set __CrossgenAltJit=
set __BuildXUnitWrappers=
set __PrintLastResultsOnly=
set RunInUnloadableContext=

Expand Down Expand Up @@ -71,7 +70,6 @@ if /i "%1" == "jitforcerelocs" (set COMPlus_ForceRelocs
if /i "%1" == "jitdisasm" (set __JitDisasm=1&shift&goto Arg_Loop)
if /i "%1" == "ilasmroundtrip" (set __IlasmRoundTrip=1&shift&goto Arg_Loop)

if /i "%1" == "buildxunitwrappers" (set __BuildXunitWrappers=1&shift&goto Arg_Loop)
if /i "%1" == "printlastresultsonly" (set __PrintLastResultsOnly=1&shift&goto Arg_Loop)
if /i "%1" == "runcrossgentests" (set RunCrossGen=true&shift&goto Arg_Loop)
if /i "%1" == "runcrossgen2tests" (set RunCrossGen2=true&shift&goto Arg_Loop)
Expand Down Expand Up @@ -153,10 +151,6 @@ if defined __Sequential (
set __RuntestPyArgs=%__RuntestPyArgs% --sequential
)

if defined __BuildXUnitWrappers (
set __RuntestPyArgs=%__RuntestPyArgs% --build_xunit_test_wrappers
)

if defined RunCrossGen (
set __RuntestPyArgs=%__RuntestPyArgs% --run_crossgen_tests
)
Expand Down
12 changes: 0 additions & 12 deletions src/coreclr/tests/runtest.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ function print_usage {
echo ' --tieredcompilation : Runs the tests with COMPlus_TieredCompilation=1'
echo ' --link <ILlink> : Runs the tests after linking via ILlink'
echo ' --xunitOutputPath=<path> : Create xUnit XML report at the specifed path (default: <test root>/coreclrtests.xml)'
echo ' --buildXUnitWrappers : Force creating the xunit wrappers, this is useful if there have been changes to issues.targets'
echo ' --printLastResultsOnly : Print the results of the last run'
echo ' --runincontext : Run each tests in an unloadable AssemblyLoadContext'
echo ''
Expand Down Expand Up @@ -218,7 +217,6 @@ verbose=0
doCrossgen=0
jitdisasm=0
ilasmroundtrip=
buildXUnitWrappers=
printLastResultsOnly=
runSequential=0
runincontext=0
Expand Down Expand Up @@ -254,9 +252,6 @@ do
release|Release)
buildConfiguration="Release"
;;
--buildXUnitWrappers)
buildXUnitWrappers=1
;;
--printLastResultsOnly)
printLastResultsOnly=1
;;
Expand Down Expand Up @@ -504,13 +499,6 @@ if [ ! -z "$ilasmroundtrip" ]; then
runtestPyArguments+=("--ilasmroundtrip")
fi

if [ ! -z "$buildXUnitWrappers" ]; then
runtestPyArguments+=("--build_xunit_test_wrappers")
else
echo "Skipping xunit wrapper build. If build-test was called on a different"
echo "host_os or arch the test run will most likely have failures."
fi

if (($verbose!=0)); then
runtestPyArguments+=("--verbose")
fi
Expand Down