Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Fix msvc mono build and add CopyMonoRuntimeFilesFromArtifactsToDestination target #32130

Merged
merged 6 commits into from
Feb 17, 2020

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Feb 11, 2020

Fixes

fatal error C1083: Cannot open include file: '../../support/libm/complex.c': No such file or directory

when mono-netcore.sln is opened in vs2019

Also, add CopyMonoRuntimeFilesFromArtifactsToDestination target to mono.proj to be able to copy mono runtime bits to any folder (needed for the performance team, cc @fanyang-mono)

Copy link
Member

@akoeplinger akoeplinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't do that since this file is mirrored with mono/mono.

@akoeplinger
Copy link
Member

Maybe one way would be to check whether ../mono.proj exists (or some other file that only exists in dotnet/runtime) and default the property to true in that case?

@EgorBo EgorBo changed the title [mono] Fix msvc mono build [mono] Fix msvc mono build and add CopyMonoRuntimeFilesFromArtifactsToDestination target Feb 11, 2020
@EgorBo EgorBo merged commit 76b4d64 into dotnet:master Feb 17, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants