Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure: System.Net.NetworkInformation.Tests.NetworkInterfaceBasicTest/BasicTest_AccessInstanceProperties_NoExceptions_Linux #18090

Closed
ghost opened this issue Aug 15, 2016 · 16 comments · Fixed by #32223
Assignees
Labels
area-System.Net disabled-test The test is disabled in source code against the issue os-linux Linux OS (any supported distro)
Milestone

Comments

@ghost
Copy link

ghost commented Aug 15, 2016

Opened on behalf of @jiangzeng

The test System.Net.NetworkInformation.Tests.NetworkInterfaceBasicTest/BasicTest_AccessInstanceProperties_NoExceptions_Linux has failed.

Assert.InRange() Failure\r
Range:  (0 - 9223372036854775807)\r
Actual: -1

Stack Trace:

   at System.Net.NetworkInformation.Tests.NetworkInterfaceBasicTest.BasicTest_AccessInstanceProperties_NoExceptions_Linux()

Failing configurations:

  • Fedora.23.Amd64
    • AnyCPU-Debug
    • AnyCPU-Release
@mellinoe
Copy link
Contributor

mellinoe commented Sep 16, 2016

@ericeil I'm seeing this in some Ubuntu 16.10 runs as well. I'm pretty sure that the only way this could happen is if the actual statistics file from the system (/sys/class/net//speed) actually contains "-1" instead of a real speed value. I think we should just return null from the parsing routine in that case; it already returns null for other invalid values / IO errors.

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.0.0 milestone Jan 31, 2020
@ViktorHofer ViktorHofer reopened this Feb 12, 2020
@ViktorHofer ViktorHofer modified the milestones: 2.0.0, 5.0 Feb 12, 2020
@ViktorHofer
Copy link
Member

Failing constantly again. Reopening.

System.Net.NetworkInformation.Tests.NetworkInterfaceBasicTest.BasicTest_AccessInstanceProperties_NoExceptions_Linux

netcoreapp5.0-Linux-Release-x64-Mono_release-Ubuntu.1804.Amd64.Open
netcoreapp5.0-Linux-Release-x64-Mono_release-RedHat.7.Amd64.Open
netcoreapp5.0-Linux-Release-x64-CoreCLR_checked-Ubuntu.1804.Amd64.Open
netcoreapp5.0-Linux-Release-x64-CoreCLR_release-Ubuntu.1804.Amd64.Open
netcoreapp5.0-Linux-Release-x64-CoreCLR_release-RedHat.7.Amd64.Open

Assert.InRange() Failure\r\nRange: (-1 - 9223372036854775807)\r\nActual: -1539607552
 at System.Net.NetworkInformation.Tests.NetworkInterfaceBasicTest.BasicTest_AccessInstanceProperties_NoExceptions_Linux() in /_/src/libraries/System.Net.NetworkInformation/tests/FunctionalTests/NetworkInterfaceBasicTest.cs:line 75
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) in /_/src/mono/netcore/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs:line 339

@ManickaP
Copy link
Member

It fails on Assert.InRange(nic.Speed, -1, long.MaxValue); . I think it might be the conversion to int here: https://github.com/dotnet/runtime/blob/master/src/libraries/Native/Unix/System.Native/pal_interfaceaddresses.c#L376, because the function itself returns uint: https://elixir.bootlin.com/linux/v5.5.3/source/include/uapi/linux/ethtool.h#L123.
@wfurt Unless you immediately know what the problem is and the fix would literally take you just few minutes, I'll look into it. Seems like fun investigation 😄

@CoffeeFlux
Copy link
Contributor

Hit on #2098

@akoeplinger
Copy link
Member

Another tracking issue for this: #32179

@jaredpar
Copy link
Member

Not sure why my GitHub search didn't turn up this issue. Closing #32179 and using this as the primary. Will bring the test failure table over here.

@jaredpar
Copy link
Member

System.Net.NetworkInformation.Functional.Tests Work Item

Console Log Summary

===========================================================================================================
~/work/AFA10939/w/A8C90920/e ~/work/AFA10939/w/A8C90920/e
  Discovering: System.Net.NetworkInformation.Functional.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Net.NetworkInformation.Functional.Tests (found 75 of 92 test cases)
  Starting:    System.Net.NetworkInformation.Functional.Tests (parallel test collections = on, max threads = 2)
    System.Net.NetworkInformation.Tests.NetworkInterfaceBasicTest.BasicTest_AccessInstanceProperties_NoExceptions_Linux [FAIL]
      Assert.InRange() Failure
      Range:  (-1 - 9223372036854775807)
      Actual: -1539607552
      Stack Trace:
        /_/src/libraries/System.Net.NetworkInformation/tests/FunctionalTests/NetworkInterfaceBasicTest.cs(75,0): at System.Net.NetworkInformation.Tests.NetworkInterfaceBasicTest.BasicTest_AccessInstanceProperties_NoExceptions_Linux()
      Output:
        - NetworkInterface -
        Name: lo
        Description: lo
        ID: lo
        Type: Loopback
        Status: Up
        Speed: -1
        SupportsMulticast: False
        GetPhysicalAddress(): 
        - NetworkInterface -
        Name: eth0
        Description: eth0
        ID: eth0
        Type: Ethernet
        Status: Up
        Speed: -1539607552
  Finished:    System.Net.NetworkInformation.Functional.Tests
=== TEST EXECUTION SUMMARY ===

Builds

Build Pull Request Test Failure Count
#515813 #1273 6
#516798 #2098 13
#516907 #31892 24
#517052 Rolling 7
#517102 #32155 9
#517112 #32157 7
#517133 #31834 1
#517135 #32158 2
#517142 #32159 2
#517177 #31898 7
#517179 Rolling 8
#517188 #32143 7
#517193 #32090 19
#517197 #32155 7
#517210 #32160 1
#517242 Rolling 5
#517252 #2111 9
#517290 #32160 6
#517322 Rolling 7
#517332 #31744 9
#517344 #32162 3
#517347 #32163 3
#517393 #31856 2
#517396 Rolling 3
#517427 #31957 1
#517446 Rolling 12
#517466 #32127 12
#517470 #32167 1
#517476 #32169 1
#517489 #771 3
#517491 #32170 3
#517495 #32039 3
#517500 #32032 4
#517502 #32130 5
#517515 Rolling 4
#517567 #31953 8
#517617 #32173 8
#517643 #32115 9
#517645 #32174 7

Configurations

  • netcoreapp5.0-Linux-Debug-x64-CoreCLR_checked-Ubuntu.1804.Amd64.Open
  • netcoreapp5.0-Linux-Debug-x64-CoreCLR_release-Centos.7.Amd64.Open
  • netcoreapp5.0-Linux-Debug-x64-CoreCLR_release-Debian.9.Amd64.Open
  • netcoreapp5.0-Linux-Debug-x64-CoreCLR_release-RedHat.7.Amd64.Open
  • netcoreapp5.0-Linux-Debug-x64-CoreCLR_release-SLES.15.Amd64.Open
  • netcoreapp5.0-Linux-Debug-x64-CoreCLR_release-Ubuntu.1604.Amd64.Open
  • netcoreapp5.0-Linux-Debug-x64-CoreCLR_release-Ubuntu.1804.Amd64.Open
  • netcoreapp5.0-Linux-Debug-x64-Mono_release-Centos.7.Amd64.Open
  • netcoreapp5.0-Linux-Debug-x64-Mono_release-Debian.9.Amd64.Open
  • netcoreapp5.0-Linux-Debug-x64-Mono_release-RedHat.7.Amd64.Open
  • netcoreapp5.0-Linux-Debug-x64-Mono_release-SLES.15.Amd64.Open
  • netcoreapp5.0-Linux-Debug-x64-Mono_release-Ubuntu.1604.Amd64.Open
  • netcoreapp5.0-Linux-Debug-x64-Mono_release-Ubuntu.1804.Amd64.Open
  • netcoreapp5.0-Linux-Release-x64-CoreCLR_checked-Ubuntu.1804.Amd64.Open
  • netcoreapp5.0-Linux-Release-x64-CoreCLR_release-Centos.7.Amd64.Open
  • netcoreapp5.0-Linux-Release-x64-CoreCLR_release-Debian.9.Amd64.Open
  • netcoreapp5.0-Linux-Release-x64-CoreCLR_release-RedHat.7.Amd64.Open
  • netcoreapp5.0-Linux-Release-x64-CoreCLR_release-SLES.15.Amd64.Open
  • netcoreapp5.0-Linux-Release-x64-CoreCLR_release-Ubuntu.1604.Amd64.Open
  • netcoreapp5.0-Linux-Release-x64-CoreCLR_release-Ubuntu.1804.Amd64.Open
  • netcoreapp5.0-Linux-Release-x64-Mono_release-Centos.7.Amd64.Open
  • netcoreapp5.0-Linux-Release-x64-Mono_release-Debian.9.Amd64.Open
  • netcoreapp5.0-Linux-Release-x64-Mono_release-RedHat.7.Amd64.Open
  • netcoreapp5.0-Linux-Release-x64-Mono_release-SLES.15.Amd64.Open
  • netcoreapp5.0-Linux-Release-x64-Mono_release-Ubuntu.1604.Amd64.Open
  • netcoreapp5.0-Linux-Release-x64-Mono_release-Ubuntu.1804.Amd64.Open
  • netcoreapp5.0-Windows_NT-Release-x86-CoreCLR_release-Windows.7.Amd64.Open

Helix Logs

Build Pull Request Console Core Test Results
#515813 #1273 console.bfc8fd73.log testResults.xml
#515813 #1273 console.d35f4320.log testResults.xml
#515813 #1273 console.401c5482.log testResults.xml
#515813 #1273 console.d6fe4730.log testResults.xml
#515813 #1273 console.a0fd014f.log testResults.xml
#515813 #1273 console.2fa15153.log testResults.xml
#516798 #2098 console.bedcbf43.log testResults.xml
#516798 #2098 console.c7cf895f.log testResults.xml
#516798 #2098 console.fb746c30.log testResults.xml
#516798 #2098 console.95787925.log testResults.xml
#516798 #2098 console.e54ee8ae.log testResults.xml
#516798 #2098 console.ad5e50e2.log testResults.xml
#516798 #2098 console.81a17a71.log testResults.xml
#516798 #2098 console.fa7526c5.log testResults.xml
#516798 #2098 console.3f9bc3b3.log testResults.xml
#516798 #2098 console.ef4a10cb.log testResults.xml
#516798 #2098 console.bb4f4167.log testResults.xml
#516798 #2098 console.92e17501.log testResults.xml
#516798 #2098 console.c09ef6d0.log testResults.xml
#516907 #31892 console.56579e8f.log testResults.xml
#516907 #31892 console.0dd40997.log testResults.xml
#516907 #31892 console.d1f8ff60.log testResults.xml
#516907 #31892 console.b6face4d.log testResults.xml
#516907 #31892 console.3b527f73.log testResults.xml
#516907 #31892 console.d1b24279.log testResults.xml
#516907 #31892 console.36a77eb7.log testResults.xml
#516907 #31892 console.4a2c31c0.log testResults.xml
#516907 #31892 console.9e982a38.log testResults.xml
#516907 #31892 console.ce8ea870.log testResults.xml
#516907 #31892 console.22f5153a.log testResults.xml
#516907 #31892 console.c2db4f08.log testResults.xml
#516907 #31892 console.1d29d82a.log testResults.xml
#516907 #31892 console.d7ffcf51.log testResults.xml
#516907 #31892 console.47441cc8.log testResults.xml
#516907 #31892 console.1ff059e0.log testResults.xml
#516907 #31892 console.cba94637.log testResults.xml
#516907 #31892 console.c82e4d6f.log testResults.xml
#516907 #31892 console.d683f36b.log testResults.xml
#516907 #31892 console.e6cd59aa.log testResults.xml
#516907 #31892 console.14663776.log testResults.xml
#516907 #31892 console.419235d5.log testResults.xml
#516907 #31892 console.a3c4c8ea.log testResults.xml
#516907 #31892 console.dfbe3e2e.log testResults.xml
#517052 Rolling console.13b83b6b.log testResults.xml
#517052 Rolling console.75f33acd.log testResults.xml
#517052 Rolling console.4b55e7de.log testResults.xml
#517052 Rolling console.785a218d.log testResults.xml
#517052 Rolling console.7c110710.log testResults.xml
#517052 Rolling console.eca008af.log testResults.xml
#517052 Rolling console.deab0823.log testResults.xml
#517102 #32155 console.0c722ddf.log testResults.xml
#517102 #32155 console.3f9ab7c1.log testResults.xml
#517102 #32155 console.93da4bb7.log testResults.xml
#517102 #32155 console.d2631954.log testResults.xml
#517102 #32155 console.31506651.log testResults.xml
#517102 #32155 console.39a92f97.log testResults.xml
#517102 #32155 console.f19d8561.log testResults.xml
#517102 #32155 console.71af15fe.log testResults.xml
#517102 #32155 console.4c6b2d2d.log
#517112 #32157 console.2ee74a13.log testResults.xml
#517112 #32157 console.b0600659.log testResults.xml
#517112 #32157 console.92a6be09.log testResults.xml
#517112 #32157 console.73158922.log testResults.xml
#517112 #32157 console.7d1d8a2b.log testResults.xml
#517112 #32157 console.7c63d493.log testResults.xml
#517112 #32157 console.7a4d5ea8.log
#517133 #31834 console.4c99b333.log testResults.xml
#517135 #32158 console.07e206dc.log testResults.xml
#517135 #32158 console.1b039cbf.log testResults.xml
#517142 #32159 console.02a304a8.log testResults.xml
#517142 #32159 console.2e9d02c7.log testResults.xml
#517177 #31898 console.43c2bc9e.log testResults.xml
#517177 #31898 console.d9260ac5.log testResults.xml
#517177 #31898 console.fb0931b6.log testResults.xml
#517177 #31898 console.2d93e909.log testResults.xml
#517177 #31898 console.e03bcf9a.log testResults.xml
#517177 #31898 console.b3fb0581.log testResults.xml
#517177 #31898 console.0f8b6e44.log
#517179 Rolling console.5da3346b.log testResults.xml
#517179 Rolling console.9885d92b.log testResults.xml
#517179 Rolling console.f5c1817d.log testResults.xml
#517179 Rolling console.59c93740.log testResults.xml
#517179 Rolling console.2433259d.log testResults.xml
#517179 Rolling console.1d75a5b5.log testResults.xml
#517179 Rolling console.deb1ca94.log testResults.xml
#517179 Rolling console.3001f063.log
#517188 #32143 console.8ffca319.log testResults.xml
#517188 #32143 console.2a4a886b.log testResults.xml
#517188 #32143 console.d9c3a916.log testResults.xml
#517188 #32143 console.fce93f0b.log testResults.xml
#517188 #32143 console.f6c15759.log testResults.xml
#517188 #32143 console.41ba79dc.log testResults.xml
#517188 #32143 console.28687b26.log
#517193 #32090 console.c8b7979c.log testResults.xml
#517193 #32090 console.a77521cd.log testResults.xml
#517193 #32090 console.fff487aa.log testResults.xml
#517193 #32090 console.4cfc51e3.log testResults.xml
#517193 #32090 console.2308a507.log testResults.xml
#517193 #32090 console.dd2ea8b0.log testResults.xml
#517193 #32090 console.06314959.log testResults.xml
#517193 #32090 console.0ba3edef.log testResults.xml
#517193 #32090 console.e0c03e9b.log testResults.xml
#517193 #32090 console.a50a4350.log testResults.xml
#517193 #32090 console.47601119.log testResults.xml
#517193 #32090 console.a1670520.log testResults.xml
#517193 #32090 console.5c7d86ed.log testResults.xml
#517193 #32090 console.2945f8e8.log testResults.xml
#517193 #32090 console.89e0371b.log testResults.xml
#517193 #32090 console.3be3e2f3.log testResults.xml
#517193 #32090 console.ca406c2e.log testResults.xml
#517193 #32090
#517193 #32090 console.a8c5d1dd.log
#517197 #32155 console.f9114c88.log testResults.xml
#517197 #32155 console.6e9f7330.log testResults.xml
#517197 #32155 console.329b936e.log testResults.xml
#517197 #32155 console.09abae8b.log testResults.xml
#517197 #32155 console.f7d695b7.log testResults.xml
#517197 #32155 console.d730ca4a.log testResults.xml
#517197 #32155 console.4e7ade5b.log
#517210 #32160 console.e8f079ee.log
#517242 Rolling console.490c61bb.log testResults.xml
#517242 Rolling console.289ba663.log testResults.xml
#517242 Rolling console.ccd1f073.log testResults.xml
#517242 Rolling console.033d3b06.log testResults.xml
#517242 Rolling console.3bd7a4a1.log testResults.xml
#517252 #2111 console.12a4833b.log testResults.xml
#517252 #2111 console.cb9366f9.log testResults.xml
#517252 #2111 console.5f7a7350.log testResults.xml
#517252 #2111 console.68af2e4e.log testResults.xml
#517252 #2111 console.e46c5cbf.log testResults.xml
#517252 #2111 console.b7fc0073.log testResults.xml
#517252 #2111 console.5150edfd.log testResults.xml
#517252 #2111 console.756ec1d0.log testResults.xml
#517252 #2111 console.2736282e.log
#517290 #32160 console.974ccdb3.log testResults.xml
#517290 #32160 console.23494a28.log testResults.xml
#517290 #32160 console.88e4a47d.log testResults.xml
#517290 #32160 console.0feeb36c.log testResults.xml
#517290 #32160 console.edf34ddb.log testResults.xml
#517290 #32160 console.c3c0e1dc.log testResults.xml
#517322 Rolling console.1db9df7e.log testResults.xml
#517322 Rolling console.c8ba9959.log testResults.xml
#517322 Rolling console.8c8dc59e.log testResults.xml
#517322 Rolling console.e61a1cec.log testResults.xml
#517322 Rolling console.6431dd6a.log testResults.xml
#517322 Rolling console.029a57f5.log testResults.xml
#517322 Rolling console.17347a5b.log testResults.xml
#517332 #31744 console.1d49a0fb.log testResults.xml
#517332 #31744 console.b5f2ac27.log testResults.xml
#517332 #31744 console.89f1fa5f.log testResults.xml
#517332 #31744 console.93f65a54.log testResults.xml
#517332 #31744 console.21a8d495.log testResults.xml
#517332 #31744 console.d09dab1e.log testResults.xml
#517332 #31744 console.bd3d67e9.log testResults.xml
#517332 #31744 console.32d6a9a4.log testResults.xml
#517332 #31744 console.19b6de3c.log testResults.xml
#517344 #32162 console.de4d50eb.log testResults.xml
#517344 #32162 console.b7f2972e.log testResults.xml
#517344 #32162 console.2942b1b1.log testResults.xml
#517347 #32163 console.811b3638.log testResults.xml
#517347 #32163 console.1ff5eeb8.log testResults.xml
#517347 #32163 console.f8cd2be1.log testResults.xml
#517393 #31856 console.c7bb16d2.log testResults.xml
#517393 #31856 console.fbe90636.log testResults.xml
#517396 Rolling console.023a13e8.log testResults.xml
#517396 Rolling console.8da0ffee.log testResults.xml
#517396 Rolling console.c6ec052e.log testResults.xml
#517427 #31957 console.8e127a42.log testResults.xml
#517446 Rolling console.f8254e78.log testResults.xml
#517446 Rolling console.f59a594b.log testResults.xml
#517446 Rolling console.ab9f9699.log testResults.xml
#517446 Rolling console.cca21681.log testResults.xml
#517446 Rolling console.789f669a.log testResults.xml
#517446 Rolling console.25660a99.log testResults.xml
#517446 Rolling console.aea900b7.log testResults.xml
#517446 Rolling console.b12416d6.log testResults.xml
#517446 Rolling console.5dd1d04a.log testResults.xml
#517446 Rolling console.fd0f2f9d.log testResults.xml
#517446 Rolling console.7094ca85.log testResults.xml
#517446 Rolling console.ad9343a6.log
#517466 #32127 console.66371370.log testResults.xml
#517466 #32127 console.cc1e0f9c.log testResults.xml
#517466 #32127 console.977f4e16.log testResults.xml
#517466 #32127 console.9b6c0df7.log testResults.xml
#517466 #32127 console.7cc7880f.log testResults.xml
#517466 #32127 console.f120df0b.log testResults.xml
#517466 #32127 console.1e198223.log testResults.xml
#517466 #32127 console.6f6b9237.log testResults.xml
#517466 #32127 console.e4264419.log testResults.xml
#517466 #32127 console.27539486.log testResults.xml
#517466 #32127 console.f6d531b3.log testResults.xml
#517466 #32127 console.612b478d.log
#517470 #32167 console.58f43c1a.log testResults.xml
#517476 #32169 console.ce766dee.log testResults.xml
#517489 #771 console.997a2c28.log testResults.xml
#517489 #771 console.fc8f42e0.log testResults.xml
#517489 #771 console.8d8142bb.log testResults.xml
#517491 #32170 console.ae5a6842.log testResults.xml
#517491 #32170 console.aef80e71.log testResults.xml
#517491 #32170 console.6b580c12.log testResults.xml
#517495 #32039 console.aaea89c2.log testResults.xml
#517495 #32039 console.a2d28249.log testResults.xml
#517495 #32039 console.a43ce32d.log testResults.xml
#517500 #32032 console.ed73ae31.log testResults.xml
#517500 #32032 console.9bec1e47.log testResults.xml
#517500 #32032 console.53588327.log testResults.xml
#517500 #32032 console.bfbb45b8.log testResults.xml
#517502 #32130 console.51fe8cbe.log testResults.xml
#517502 #32130 console.a80fbcbe.log testResults.xml
#517502 #32130 console.7f15a80b.log testResults.xml
#517502 #32130 console.3e2a55ce.log testResults.xml
#517502 #32130 console.5bd5e9e1.log testResults.xml
#517515 Rolling console.85a0fd36.log testResults.xml
#517515 Rolling console.f4893e4f.log testResults.xml
#517515 Rolling console.12e1bacc.log testResults.xml
#517515 Rolling console.2d80c08f.log testResults.xml
#517567 #31953 console.2c0713fc.log testResults.xml
#517567 #31953 console.2f098b3b.log testResults.xml
#517567 #31953 console.4c580bc2.log testResults.xml
#517567 #31953 console.40fc3e91.log testResults.xml
#517567 #31953 console.bb037f39.log testResults.xml
#517567 #31953 console.c8545f11.log testResults.xml
#517567 #31953 console.cefdc994.log testResults.xml
#517567 #31953 console.e7ddc4c9.log testResults.xml
#517617 #32173 console.709445c9.log testResults.xml
#517617 #32173 console.9115f97e.log testResults.xml
#517617 #32173 console.76dd5662.log testResults.xml
#517617 #32173 console.4598814a.log testResults.xml
#517617 #32173 console.29a4167c.log testResults.xml
#517617 #32173 console.392adda1.log testResults.xml
#517617 #32173 console.5447dbf5.log testResults.xml
#517617 #32173 console.c132a8d2.log testResults.xml
#517643 #32115 console.8bacdc33.log testResults.xml
#517643 #32115 console.66bb9743.log testResults.xml
#517643 #32115 console.6725b08c.log testResults.xml
#517643 #32115 console.110e7374.log testResults.xml
#517643 #32115 console.45065945.log testResults.xml
#517643 #32115 console.b58359c0.log testResults.xml
#517643 #32115 console.2b316156.log testResults.xml
#517643 #32115 console.2eef37b5.log testResults.xml
#517643 #32115 console.bc4b492f.log
#517645 #32174 console.41c90e5d.log testResults.xml
#517645 #32174 console.12011cdf.log testResults.xml
#517645 #32174 console.8553918c.log testResults.xml
#517645 #32174 console.f41a9e83.log testResults.xml
#517645 #32174 console.8a34b262.log testResults.xml
#517645 #32174 console.9d886fd0.log testResults.xml
#517645 #32174 console.2a858300.log

@jaredpar
Copy link
Member

As a part of actually fixing this bug I think we need to do a root cause investigation here given the wide scale impact of this break. It essentially took down all builds for quite a long period of time.

@jaredpar
Copy link
Member

jaredpar commented Feb 12, 2020

@ManickaP if you're looking into this may want to take a look at #1273. That may be the source of these failures. It's the earliest reference I can find to the break.

@davidsh davidsh added the disabled-test The test is disabled in source code against the issue label Feb 12, 2020
@Anipik
Copy link
Contributor

Anipik commented Feb 12, 2020

A bsd version of this test System.Net.NetworkInformation.Tests.NetworkInterfaceBasicTest.BasicTest_AccessInstanceProperties_NoExceptions_bsd fails in dotnet/corefx#42850

https://helix.dot.net/api/2019-06-17/jobs/48eecc4c-5977-4aab-99bf-199a1cf97334/workitems/System.Net.NetworkInformation.Functional.Tests/console

This in 3.1 branch

@wfurt
Copy link
Member

wfurt commented Feb 12, 2020

@wfurt Unless you immediately know what the problem is and the fix would literally take you just a few minutes, I'll look into it. Seems like fun investigation

no, I don't. At least for the OSX failures, it feels like something changes with the infrastructure. Since loopback should not really have speed, I would expect this to be -1.

@wfurt
Copy link
Member

wfurt commented Feb 12, 2020

actually, never mind. I look at the wrong part @ManickaP. We should capture the output of ethtool eth0 on failure or you can update RunTest.sh to do that and try to get repro with a private run.

Fox OSX we should get output of networksetup -listallhardwareports ; ifconfig -a

@ManickaP ManickaP self-assigned this Feb 13, 2020
@ManickaP
Copy link
Member

So I added the ethtool eth0 into RunTest.sh and got this:

Settings for eth0:
	Supported ports: [ ]
	Supported link modes:   Not reported
	Supported pause frame use: No
	Supports auto-negotiation: No
	Supported FEC modes: Not reported
	Advertised link modes:  Not reported
	Advertised pause frame use: No
	Advertised auto-negotiation: No
	Advertised FEC modes: Not reported
	Speed: 50000Mb/s
	Duplex: Full
	Port: Other
	PHYAD: 0
	Transceiver: internal
	Auto-negotiation: off
	Link detected: yes

For instance in: https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-32223-merge-389ed0c11d0c4fedb6/System.Net.NetworkInformation.Functional.Tests/console.ec529df2.log?sv=2019-02-02&se=2020-02-23T13%3A17%3A47Z&sr=c&sp=rl&sig=keU1SXAgQX57de4XmOeEL%2FT5IO9iN7xD%2BuOE7LwtZu0%3D. More can be found in the failed tests of this WIP PR #32223.

The problem isn't in the cast, but in the multiplying by 1 000 000 in here: https://github.com/dotnet/runtime/blob/master/src/libraries/Native/Unix/System.Native/pal_interfaceaddresses.c#L380
If you let unchecked(50000*1000000) overflow in int32, you'll get the incriminating -1539607552.

@wfurt
Copy link
Member

wfurt commented Feb 13, 2020

Good find @ManickaP. Probably time to bump it to long to get ready for 100G and beyond.

@ManickaP
Copy link
Member

Good find @ManickaP. Probably time to bump it to long to get ready for 100G and beyond.

I'm already running tests in my PR for this fix.

@jaredpar
Copy link
Member

@ManickaP thanks for tracking this down!

ManickaP added a commit that referenced this issue Feb 14, 2020
Fixes #18090

Linux pal level struct for network info had only int32 field for speed. Even though our public API has it as long. The problem was in value overflowing in calculation MBits --> Bits.
@ghost ghost locked as resolved and limited conversation to collaborators Dec 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net disabled-test The test is disabled in source code against the issue os-linux Linux OS (any supported distro)
Projects
None yet
Development

Successfully merging a pull request may close this issue.