Update ILLinkTasksVersion dependency #32170
Conversation
…otnet#31807)" This reverts commit 334391b.
marek-safar
changed the title
|
@marek-safar I assume this also includes the fix to not strip out assembly attributes which caused our official builds to fail? |
| @@ -13,7 +13,7 @@ | |||
| <_ILLinkTrimXmlFilePath Condition=" '$(_ILLinkTrimXmlFilePath)' == '' ">$(MSBuildThisFileDirectory)ILLinkTrim.xml</_ILLinkTrimXmlFilePath> | |||
| <_ILLinkTasksToolsDir>$(PkgILLink_Tasks)/tools</_ILLinkTasksToolsDir> | |||
| <_ILLinkTasksDir>$(_ILLinkTasksToolsDir)/$(NetFrameworkCurrent)/</_ILLinkTasksDir> | |||
| <_ILLinkTasksDir Condition="'$(MSBuildRuntimeType)' == 'Core'">$(_ILLinkTasksToolsDir)/netcoreapp2.0/</_ILLinkTasksDir> | |||
| <_ILLinkTasksDir Condition="'$(MSBuildRuntimeType)' == 'Core'">$(_ILLinkTasksToolsDir)/netcoreapp3.0/</_ILLinkTasksDir> | |||
There was a problem hiding this comment.
We should instead remove the property that calculates the path to the illink directory and instead use the defined one in L27 that comes via the package: https://github.com/mono/linker/blob/e5d6b69677dfc0da19c5b2c96b3466e8d5016327/src/ILLink.Tasks/ILLink.Tasks.targets#L8
There was a problem hiding this comment.
Good suggestion but as this needs more work it should be done in different PR (tracking issue #32453)
There was a problem hiding this comment.
works for me, thanks for opening the issue.
@ViktorHofer yes, the tests were enabled and would fail without the fix |
|
Failures are #32320 |
|
I just re-enabled the subscription. |
ghost
locked as resolved and limited conversation to collaborators
This reverts commit 334391b and allows re-enabling linker darc subscription