-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Arm64] Add ASIMD pairwise reduce instructions #32277
[Arm64] Add ASIMD pairwise reduce instructions #32277
Conversation
…emitfmtsarm64.h instrsarm64.h
…emitfmtsarm64.h instrsarm64.h
@dotnet/jit-contrib PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good
After multiple attempts to retry runtime (Libraries Test Run checked coreclr OSX x64 Debug) continues failing with
@dotnet/runtime-infrastructure Is this a known/tracked issue? When I tried to open some of the links in the failure log I got either
or 404 error. I am merging this change anyway since it doesn't affect x64 side of runtime. |
I believe @ViktorHofer mentioned earlier today there's a known "permission denied" issue hitting OSX runs overall. |
Yeah, that issue is tracked here: https://github.com/dotnet/core-eng/issues/8971 |
This adds the following Arm64 instructions:
I validate that the encodings are right by comparing the output of JIT dump with WinDbg u and
ALL_ARM64_EMITTER_UNIT_TESTS
macro defined.In addition, I fixed the emitter tests for smaxv, sminv, umaxv, uminv, trn1, trn2, uzp1, uzp2, zip1, zip2.