[llvm] Define a separate symbol for the aot method info for every method. Pass this symbol to the init functions instead of the method index. #34009
+174
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monojenkins
requested review from
alexischr,
CoffeeFlux,
EgorBo,
imhameed,
lambdageek,
lewurm,
SamMonoRT and
vargaz
as code owners
monojenkins
force-pushed
the
sync-pr-19298-from-mono
branch
2 times, most recently
from
b35af17 to
6b11554
Compare
…hod. Pass this symbol to the init functions instead of the method index. This removes a dependency the generated code has on the method index, hopefully allowing separate compilation etc. in the future. <!-- Thank you for your Pull Request! If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed. Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number -->
monojenkins
force-pushed
the
sync-pr-19298-from-mono
branch
from
6b11554 to
23e4d09
Compare
vargaz
approved these changes
Apr 6, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!! This PR is a copy of mono/mono#19298, please do not edit or review it in this repo !!
Do not automatically approve this PR:
* Consider how the changes affect configurations in this repo,
* Check effects on files that are not mirrored,
* Identify test cases that may be needed in this repo.
!! Merge the PR only after the original PR is merged !!
This removes a dependency the generated code has on the method index, hopefully allowing separate compilation etc. in the future.