[llvm] Define a separate symbol for the aot method info for every method. Pass this symbol to the init functions instead of the method index. #19298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vargaz
requested review from
imhameed,
lambdageek,
lewurm and
SamMonoRT
as code owners
|
This also reduces code size on wasm a bit, presumably because the method_info_offsets table becomes smaller, since it contains more 0s. |
|
@monojenkins build failed |
imhameed
approved these changes
Apr 6, 2020
…hod. Pass this symbol to the init functions instead of the method index. This removes a dependency the generated code has on the method index, hopefully allowing separate compilation etc. in the future.
…d without decoding the method info structure, which is not available to the runtime for LLVM methods.
…he init flag to be changed to a per-method scalar later to remove a dependency on the method index. Also rename init_icall_wrapper to init_func, it does much more than just calling the icall.
|
@monojenkins build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a dependency the generated code has on the method index, hopefully allowing separate compilation etc. in the future.