Report POH in ETW events #34549
Merged
Report POH in ETW events #34549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Made new ETW event versions backwards compatible. Now this is ready for review. |
|
Created an issue in perfview repo to add support for this on PerfView side once this PR is merged. - microsoft/perfview#1146 |
Maoni0
reviewed
Apr 8, 2020
src/coreclr/src/gc/gcee.cpp
Outdated
| { | ||
| uint8_t* address = heap_segment_mem (seg); | ||
| size_t size = heap_segment_reserved (seg) - heap_segment_mem (seg); | ||
| gc_etw_segment_type segment_type = (i == 3) ? |
There was a problem hiding this comment.
gc_etw_segment_type segment_type = (i == 3) ? [](start = 15, length = 46)
why not do (i == loh_generation) here?
There was a problem hiding this comment.
Just did not think about it. It does seem odd.
Maoni0
requested changes
Apr 8, 2020
|
Thanks!!! |
|
Hello @VSadov! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up item for: #13731
=== When existing events have a way to specify generation, just report POH.
descr_generations_to_profiler)=== Extend existing events to fit POH.