Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux arm/arm64 libraries checked coreclr test runs #36910

Merged
merged 3 commits into from
May 28, 2020

Conversation

safern
Copy link
Member

@safern safern commented May 22, 2020

We should be running libraries tests on checked coreclr in arm/arm64 -- if we want to add these for mono as well, I'll let @naricc and @SamMonoRT to confirm... I can put up a follow up PR if needed.

This depends on: #36909

For more details: #36909 (comment)

cc: @dotnet/runtime-infrastructure @sdmaclea

@ghost
Copy link

ghost commented May 22, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@jashook
Copy link
Contributor

jashook commented May 22, 2020

Lets add one runtime at a time in case we hit capacity issues.

@safern
Copy link
Member Author

safern commented May 23, 2020

Lets add one runtime at a time in case we hit capacity issues.

Makes sense.

@naricc
Copy link
Contributor

naricc commented May 23, 2020

I haven't actually been working on the libraries tests for mono, only the runtime tests, so I'm not sure if there is a reason they have not been enabled on arm64, although I think we will eventually want to. @EgorBo @steveisok Do you know?

@SamMonoRT
Copy link
Member

This is something we want to enable for Mono runtime too. This is being tracked via the first table in #33381 @steveisok is tracking that work.

@jashook
Copy link
Contributor

jashook commented May 26, 2020

@safern looks like there is a test that should be disabled?

@safern
Copy link
Member Author

safern commented May 26, 2020

@safern looks like there is a test that should be disabled?

Yeah. I'll update the PR.

Also I think we should also include alpine_arm64, what do you think?

@sdmaclea
Copy link
Contributor

alpine_arm64 is apparently the only one which would have caught the libunwind regression.

@jkoritzinsky
Copy link
Member

We should definitely include an Alpine leg in PR runs if possible. We would have caught the issue with Alpine test runs using the dotnet CLI if we had an alpine run.

@jashook
Copy link
Contributor

jashook commented May 26, 2020

Would this have been caught with alpine arm64 runtime tests?

@safern
Copy link
Member Author

safern commented May 26, 2020

Would this have been caught with alpine arm64 runtime tests?

Yeah.

@jkoritzinsky
Copy link
Member

Actually, yes, that's where they would have been caught.

@jashook
Copy link
Contributor

jashook commented May 26, 2020

That seems to be the larger issue then

@safern
Copy link
Member Author

safern commented May 27, 2020

@jashook looks good? In case this is green I'd like to merge.

@safern safern merged commit 344085b into dotnet:master May 28, 2020
BruceForstall added a commit to BruceForstall/runtime that referenced this pull request Jul 30, 2020
Issue: dotnet#36910

See if this fails again in the CI
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants