Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable BitmapTests #40126

Closed

Conversation

BruceForstall
Copy link
Member

Issue: #36910

See if this fails again in the CI

Issue: dotnet#36910

See if this fails again in the CI
@BruceForstall
Copy link
Member Author

@safern You disabled this in a previous change. I propose to re-enable the tests to see if the problem still occurs.

What would be a way to pre-test this? Do I need to trigger something to get the checked runtime + libraries testing?

@safern
Copy link
Member

safern commented Jul 30, 2020

If you add a change to any file under src/coreclr, even a dummy comment or whatever that will run the tests against a checked coreclr.

@BruceForstall
Copy link
Member Author

Related: #37082

@BruceForstall
Copy link
Member Author

Looks like the assert came back on System.Drawing.Common.Tests

Assert failure(PID 27 [0x0000001b], Thread: 46 [0x002e]): object->HasEmptySyncBlockInfo()
    File: /__w/1/s/src/coreclr/src/vm/jithelpers.cpp Line: 2284
    Image: /root/helix/work/correlation/dotnet

https://helix.dot.net/api/2019-06-17/jobs/44dfbc95-e4bf-4708-9d3b-1bb406bc2b19/workitems/System.Drawing.Common.Tests/console

@safern
Copy link
Member

safern commented Aug 7, 2020

@BruceForstall I guess we can close this one until the fix is submitted?

@BruceForstall
Copy link
Member Author

@safern Yeah, I'll close it.

@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
@BruceForstall BruceForstall deleted the ReEnableBitmapTests branch February 28, 2021 03:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants