[wasm] Make some libc stubs return an error instead of asserting. #38256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vargaz
requested review from
alexischr,
CoffeeFlux,
lambdageek and
SamMonoRT
as code owners
alexischr
approved these changes
Jun 23, 2020
hoyosjs
added
arch-wasm
marek-safar
reviewed
Jun 23, 2020
| @@ -722,24 +722,24 @@ ssize_t sendfile(int out_fd, int in_fd, off_t *offset, size_t count); | |||
|
|
|||
| ssize_t sendfile(int out_fd, int in_fd, off_t *offset, size_t count) | |||
There was a problem hiding this comment.
Why is it done here and not at a higher level with better exception type and less code?
There was a problem hiding this comment.
These are libc stubs they should error out instead of asserting.
akoeplinger
approved these changes
Jun 23, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38164.