Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WASM] Environment.UserName raises "not supported" exception #38164

Closed
safern opened this issue Jun 19, 2020 · 3 comments · Fixed by #38256 or #38996
Closed

[WASM] Environment.UserName raises "not supported" exception #38164

safern opened this issue Jun 19, 2020 · 3 comments · Fixed by #38256 or #38996
Labels
arch-wasm WebAssembly architecture area-System.Runtime
Milestone
5.0.0

Comments

@safern
Copy link
Member

safern commented Jun 19, 2020 •
edited by akoeplinger
Loading

Update: UserName now fails with System.IO.IOException : Not supported

This is causing System.Runtime.Extensions.Tests to crash.

Crashes with:

``` at 205708 (dotnet.js:1858:32) at _emscripten_asm_const_iii (dotnet.js:1863:27) at wasm_logger (:wasm-function[7791]:0x1f3d0d) at eglib_log_adapter (:wasm-function[6303]:0x1abc50) at monoeg_g_logstr (:wasm-function[7225]:0x1ced8d) at monoeg_g_logv_nofree (:wasm-function[7223]:0x1cecb4) at monoeg_g_logv (:wasm-function[7222]:0x1cec11) at monoeg_g_log (:wasm-function[7226]:0x1ceded) at getpwuid_r (:wasm-function[1131]:0x6e9e5) at SystemNative_GetPwUidR (:wasm-function[7726]:0x1effbc) ```

I guess this API should throw PNSE in WASM?

Will disable the tests against this issue in the meantime.

cc: @steveisok @lewing @marek-safar @akoeplinger
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-ILTools-coreclr untriaged New issue has not been triaged by the area owner labels Jun 19, 2020
@safern safern added arch-wasm WebAssembly architecture area-System.Runtime and removed area-ILTools-coreclr labels Jun 19, 2020
@akoeplinger
Copy link
Member

Looks like on Xamarin iOS/Android we returned a dummy "somebody" string from Environment.UserName.

@marek-safar marek-safar added this to the 5.0.0 milestone Jun 22, 2020
@marek-safar marek-safar removed the untriaged New issue has not been triaged by the area owner label Jun 22, 2020
vargaz added a commit to vargaz/runtime that referenced this issue Jun 23, 2020
@vargaz
[wasm] Make some libc stubs return an error instead of asserting.
e804498 
Fixes dotnet#38164.
@vargaz vargaz mentioned this issue Jun 23, 2020
Merged
@monojenkins monojenkins mentioned this issue Jun 23, 2020
Merged
monojenkins pushed a commit to monojenkins/mono that referenced this issue Jun 23, 2020
@vargaz
[wasm] Make some libc stubs return an error instead of asserting.
0b34235 
Fixes dotnet/runtime#38164.
akoeplinger pushed a commit that referenced this issue Jun 23, 2020
@vargaz
[wasm] Make some libc stubs return an error instead of asserting. (#3…
178176b 
…8256)

Fixes #38164.
@akoeplinger
Copy link
Member

akoeplinger commented Jun 23, 2020 •
edited
Loading

#38256 fixed the crash but we're still reporting System.IO.IOException : Not supported from the property so we still need to fix that.

We should probably return the same dummy value that we return for Xamarin.iOS/Android.

@akoeplinger akoeplinger reopened this Jun 23, 2020
@akoeplinger akoeplinger changed the title [WASM] Environment.UserName crashes on wasm [WASM] Environment.UserName raises "not supported" exception Jun 23, 2020
@safern
Copy link
Member Author

safern commented Jun 23, 2020

Also, the test should be re-enabled or skipped without ActiveIssue before we close the issue.

runtime/src/libraries/System.Runtime.Extensions/tests/System/Environment.UserName.cs

Line 9 in 4aef3cc

[ActiveIssue("https://github.com/dotnet/runtime/issues/38164", TestPlatforms.Browser)]

@mdh1418 mdh1418 mentioned this issue Jul 10, 2020
Merged
kevinwkt pushed a commit to kevinwkt/runtimelab that referenced this issue Jul 15, 2020
@vargaz @kevinwkt
[wasm] Make some libc stubs return an error instead of asserting. (#3…
c71bf77 
…8256)

Fixes dotnet/runtime#38164.
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-System.Runtime
Projects
None yet
Milestone
5.0.0
4 participants
@marek-safar @akoeplinger @safern @Dotnet-GitSync-Bot