-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Addressing System.Runtime.Extensions failures #38996
Merged
akoeplinger
merged 22 commits into
dotnet:master
from
mdh1418:mdhwang/address_system_runtime_extensions_tests
Jul 13, 2020
Merged
[wasm] Addressing System.Runtime.Extensions failures #38996
akoeplinger
merged 22 commits into
dotnet:master
from
mdh1418:mdhwang/address_system_runtime_extensions_tests
Jul 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
jkotas
reviewed
Jul 9, 2020
src/libraries/System.Runtime.Extensions/tests/System/IO/PathTests.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jul 9, 2020
src/libraries/System.Runtime.Extensions/tests/System/StringComparer.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jul 9, 2020
src/libraries/System.Runtime.Extensions/tests/System/Environment.MachineName.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jul 9, 2020
src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jul 9, 2020
src/libraries/System.Runtime.Extensions/tests/System/IO/PathTests.cs
Outdated
Show resolved
Hide resolved
mdh1418
force-pushed
the
mdhwang/address_system_runtime_extensions_tests
branch
from
July 9, 2020 15:07
2e7ee4d
to
6577263
Compare
steveisok
reviewed
Jul 9, 2020
src/libraries/System.Runtime.Extensions/tests/System/StringComparer.cs
Outdated
Show resolved
Hide resolved
steveisok
reviewed
Jul 9, 2020
src/libraries/System.Runtime.Extensions/tests/System/StringComparer.cs
Outdated
Show resolved
Hide resolved
steveisok
reviewed
Jul 9, 2020
src/libraries/System.Runtime.Extensions/tests/System/StringComparer.cs
Outdated
Show resolved
Hide resolved
steveisok
reviewed
Jul 9, 2020
mdh1418
force-pushed
the
mdhwang/address_system_runtime_extensions_tests
branch
from
July 9, 2020 15:29
6577263
to
d6c4841
Compare
jkotas
reviewed
Jul 9, 2020
jkotas
reviewed
Jul 9, 2020
src/libraries/System.Runtime.Extensions/tests/System/Environment.Exit.cs
Show resolved
Hide resolved
99 tasks
akoeplinger
reviewed
Jul 9, 2020
src/libraries/System.Runtime.Extensions/tests/System/IO/PathTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs
Outdated
Show resolved
Hide resolved
akoeplinger
reviewed
Jul 10, 2020
src/libraries/System.Private.CoreLib/src/System/Environment.Browser.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Environment.Browser.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Environment.Browser.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jul 10, 2020
src/libraries/System.Private.CoreLib/src/System/Environment.Browser.cs
Outdated
Show resolved
Hide resolved
marek-safar
reviewed
Jul 10, 2020
src/libraries/System.Private.CoreLib/src/System/Environment.Browser.cs
Outdated
Show resolved
Hide resolved
marek-safar
reviewed
Jul 10, 2020
src/libraries/System.Private.CoreLib/src/System/Environment.Browser.cs
Outdated
Show resolved
Hide resolved
marek-safar
reviewed
Jul 10, 2020
src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs
Outdated
Show resolved
Hide resolved
safern
reviewed
Jul 10, 2020
safern
reviewed
Jul 10, 2020
src/libraries/System.Runtime.Extensions/tests/System/StringComparer.cs
Outdated
Show resolved
Hide resolved
safern
reviewed
Jul 10, 2020
src/libraries/System.Runtime.Extensions/tests/System/StringComparer.cs
Outdated
Show resolved
Hide resolved
safern
reviewed
Jul 10, 2020
src/libraries/System.Runtime.Extensions/tests/System/StringComparer.cs
Outdated
Show resolved
Hide resolved
akoeplinger
approved these changes
Jul 10, 2020
marek-safar
reviewed
Jul 11, 2020
src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems
Outdated
Show resolved
Hide resolved
marek-safar
requested changes
Jul 11, 2020
src/libraries/System.Private.CoreLib/src/System/Environment.UnixOrBrowser.cs
Outdated
Show resolved
Hide resolved
akoeplinger
approved these changes
Jul 13, 2020
marek-safar
approved these changes
Jul 13, 2020
steveisok
force-pushed
the
mdhwang/address_system_runtime_extensions_tests
branch
from
July 13, 2020 16:32
80c09c5
to
c7343fa
Compare
safern
approved these changes
Jul 13, 2020
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
Jul 29, 2020
They are no longer needed after dotnet#38996 since we return values in managed code now.
monojenkins
pushed a commit
to monojenkins/mono
that referenced
this pull request
Jul 29, 2020
They are no longer needed after dotnet/runtime#38996 since we return values in managed code now.
marek-safar
pushed a commit
that referenced
this pull request
Jul 29, 2020
They are no longer needed after #38996 since we return values in managed code now.
akoeplinger
added a commit
to mono/mono
that referenced
this pull request
Jul 29, 2020
They are no longer needed after dotnet/runtime#38996 since we return values in managed code now. Co-authored-by: akoeplinger <akoeplinger@users.noreply.github.com>
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
They are no longer needed after dotnet#38996 since we return values in managed code now.
ghost
locked as resolved and limited conversation to collaborators
Dec 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes towards #38422
Fixes #38164
This PR looks to address test failures in
System.Runtime.Extensions
when running on Browser wasm.Tests run: 6875, Errors: 0, Failures: 0, Skipped: 50. Time: 23.8534559s
This PR's changes will be integrated with changes related to environment which would account for the one failure and some skips. @steveisok
Failures