Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Console Log Formatting APIs #38616

Merged
merged 56 commits into from
Jul 15, 2020
Merged
Changes from 1 commit
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
60ccaa8
PAL_VirtualUnwindOutOfProc for MacOS (#39213)
mikem8361 Jul 15, 2020
c80cc2a
[wasm] Fix the propagation of exceptions through runtime invokes. (#3…
monojenkins Jul 15, 2020
324c6c7
Obsolete BinaryFormatter.Serialize and BinaryFormatter.Deserialize (#…
GrabYourPitchforks Jul 15, 2020
37cf387
Disallow unrestricted polymorphic deserialization in DataSet (#39304)
GrabYourPitchforks Jul 15, 2020
420e4e2
Fix location of gcdump test (#39057)
hoyosjs Jul 15, 2020
5929baa
WASM: Enable System.Memory tests (#39319)
akoeplinger Jul 15, 2020
08643df
[master] Update dependencies from mono/linker dotnet/icu (#39286)
dotnet-maestro[bot] Jul 15, 2020
1bdcd66
Add loader heap enumeration api's (ICorDebugProcess11) (#39124)
hoyosjs Jul 15, 2020
23acac8
Thumb2 uses the Arm registers (#39318)
davidwrighton Jul 15, 2020
0e7720c
Add .cfi annotation to CONTEXT_CaptureContext and RtlCaptureContext (…
janvorli Jul 15, 2020
83a15e3
[wasm] Remove ActiveIssue for issue #38337. Add a ConditionalFact ins…
vargaz Jul 15, 2020
7f53623
Add static one-shot hashing methods
vcsjones Jul 15, 2020
cd9b662
[Crossgen2] Add DelayLoadMethodCallThunks table, fix stack walks cont…
nattress Jul 15, 2020
c3a817e
Add PlatformNotSupportedException for Browser version of System.Net.S…
marek-safar Jul 15, 2020
cd8759d
Apply arm64 intrinsics to System.Text.Encodings.Web (#38707)
eiriktsarpalis Jul 15, 2020
78fb02b
Remove debug only attributes when Debugger.IsSupported is false. (#39…
eerhardt Jul 15, 2020
4cc3750
Generate only unique entries in wasm pinvoke table generator (#39356)
marek-safar Jul 15, 2020
ef2ecfd
[interp] Intrinsify span ctor (#39195)
BrzVlad Jul 15, 2020
36a9444
Disable eventpipe/gcdump test against #39361 (#39362)
jkotas Jul 15, 2020
cb08ec5
Add Structured Console Log Formatting APIs
maryamariyan Jun 30, 2020
63b95c8
Move Console tests to get better coverage results
maryamariyan Jul 7, 2020
ad23a35
Fix for config file updates
maryamariyan Jul 7, 2020
df3320a
File renames. Deprecated corrections. Code cleanup
maryamariyan Jul 7, 2020
f494d21
feedback
maryamariyan Jul 8, 2020
a7bea5e
update json formatter
maryamariyan Jul 8, 2020
2638d34
Simplify scope information for json formatter
maryamariyan Jul 8, 2020
1373353
cleanup switch expressions
maryamariyan Jul 8, 2020
9faed8f
Apply resolved feedback
maryamariyan Jul 8, 2020
6a47933
Switch back to serializing scope and state for json formatter
maryamariyan Jul 8, 2020
8652b8c
Minor fixes + parser feedback
maryamariyan Jul 9, 2020
78897a0
update test
maryamariyan Jul 9, 2020
3daf638
FormatterOptionsMonitor won't react to changes
maryamariyan Jul 9, 2020
6ae6375
Add more tests - update csproj
maryamariyan Jul 10, 2020
b6d9733
Fix build
maryamariyan Jul 10, 2020
2acdf79
Using PooledByteBufferWriter (move to Common)
maryamariyan Jul 10, 2020
3e517bb
Add code coverage
maryamariyan Jul 10, 2020
e2f7753
nit fix
maryamariyan Jul 10, 2020
353050a
Fix TargetFrameworks
maryamariyan Jul 10, 2020
ba307fd
Separate ConsoleLoggerProvider into multiple files
maryamariyan Jul 10, 2020
1582ec7
nit cleanup
maryamariyan Jul 10, 2020
0b18a7a
Fix DoesNotReturnAttribute issue
maryamariyan Jul 10, 2020
21f6630
test cleanup
maryamariyan Jul 10, 2020
f536161
net472 fix
maryamariyan Jul 10, 2020
dd97483
PR feedback
maryamariyan Jul 11, 2020
4ac06b0
simplify VT check
maryamariyan Jul 13, 2020
0ec0908
Test failure on CI troubleshoot
maryamariyan Jul 13, 2020
2edb820
updating ifdef including netframework to condition
maryamariyan Jul 13, 2020
aea00df
Test cleanup
maryamariyan Jul 13, 2020
1c062c5
AnsiLogConsole improvement
maryamariyan Jul 13, 2020
c56ab02
Fix test
maryamariyan Jul 13, 2020
d5bdc9a
header licensing fixup
maryamariyan Jul 13, 2020
a1baaff
Same logic parser, if-else flipped. Adding tests
maryamariyan Jul 14, 2020
e65a28a
Improved deprecated workflow
maryamariyan Jul 14, 2020
c048216
Improve parser adds tests
maryamariyan Jul 14, 2020
c4e3eb5
Fixing expectations for deprecated workflow
maryamariyan Jul 14, 2020
8ca5613
Fixing new netfx builds
joperezr Jul 15, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix build
maryamariyan committed Jul 15, 2020
commit b6d97333f323047c256f34538fa877a96a1e5e3e
Original file line number Diff line number Diff line change
@@ -61,11 +61,7 @@ public ConsoleLoggerProvider(IOptionsMonitor<ConsoleLoggerOptions> options, IEnu

private static bool DoesOperatingSystemSupportAnsi()
{
if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
return true;
}

#if TargetsWindows
// for Windows, check the console mode
var stdOutHandle = Interop.Kernel32.GetStdHandle(Interop.Kernel32.STD_OUTPUT_HANDLE);
if (!Interop.Kernel32.GetConsoleMode(stdOutHandle, out int consoleMode))
@@ -74,6 +70,9 @@ private static bool DoesOperatingSystemSupportAnsi()
}

return (consoleMode & Interop.Kernel32.ENABLE_VIRTUAL_TERMINAL_PROCESSING) == Interop.Kernel32.ENABLE_VIRTUAL_TERMINAL_PROCESSING;
#else
return true;
#endif
}

private void SetFormatters(IEnumerable<ConsoleFormatter> formatters = null)
Original file line number Diff line number Diff line change
@@ -24,6 +24,7 @@
<Compile Include="$(CommonPath)Extensions\Logging\NullScope.cs"
Link="Common\src\Extensions\Logging\NullScope.cs" />
</ItemGroup>

<ItemGroup Condition="'$(TargetsWindows)' == 'true'">
<Compile Include="$(CommonPath)Interop\Windows\Interop.Libraries.cs"
Link="Common\Interop\Windows\Interop.Libraries.cs" />