[Arm64] ASIMD InsertScalar and rename to ShiftLeftAndInsert ShiftRightAndInsert #38680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r in Vector128.cs
…lAndInsertScalar->ShiftLeftAndInsertScalar, ShiftRightLogicalAndInsertScalar->ShiftRightAndInsertScalar in hwintrinsiclistarm64.h
…lAndInsertScalar->ShiftLeftAndInsertScalar, ShiftRightLogicalAndInsertScalar->ShiftRightAndInsertScalar in AdvSimd.cs AdvSimd.PlatformNotSupported.cs
…Simd.PlatformNotSupported.cs
|
Tagging subscribers to this area: @tannergooding |
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
@CarolEidt @tannergooding @TamarChristinaArm PTAL cc @kunalspathak for changes in WithLower and WithUpper |
kunalspathak
reviewed
Jul 1, 2020
kunalspathak
reviewed
Jul 1, 2020
src/coreclr/tests/src/JIT/HardwareIntrinsics/Arm/AdvSimd/InsertScalar.Vector128.Double.1.cs
Show resolved
Hide resolved
tannergooding
approved these changes
Jul 2, 2020
echesakov
deleted the
Arm64-ASIMD-InsertScalar-ShiftLeftAndInsert-ShiftRightAndInsert
branch
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements InsertScalar and uses them to implement Vector128<T>.WithLower and Vector128<T>.WithUpper
Renames ShiftLeftLogicalAndInsert to ShiftLeftAndInsert and ShiftRightLogicalAndInsert to ShiftRightAndInsert as per Implement Shift and Inserts scalar and SIMD intrinsics. #36818 (comment)
Fixes #38137
I attached JitDisasm for PMI-d System.Private.CoreLib.dll for Vector128<T>.WithLower and Vector128<T>.WithUpper
System.Private.CoreLib-PMI+JitDisasm.txt