Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit arm32 Windows testing. #39655

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Limit arm32 Windows testing. #39655

merged 1 commit into from
Jul 22, 2020

Conversation

erozenfeld
Copy link
Member

Remove Windows arm32 testing from PRs. Builds are not removed.
Remove Windows arm32 jitstress testing.
Remove Windows arm32 builds from official builds.

Outerloop still has Windows arm32 builds and testing.

Resolves #38570.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 20, 2020
@erozenfeld
Copy link
Member Author

@jashook Any idea why I'm getting

Pipeline configuration error:
/eng/pipelines/coreclr/templates/xplat-job.yml: Could not retrieve file content for /eng/common/templates/job/job.yml from repository self hosted on https://github.com/ using commit df7097f3fc659c48af0cdc2886a43cd7f4fbaa07. GitHub reported the error, "Bad credentials"

https://github.com/dotnet/runtime/pull/39655/checks?check_run_id=891553015

@erozenfeld
Copy link
Member Author

@dotnet/runtime-infrastructure

Any idea why I'm getting

Pipeline configuration error:
/eng/pipelines/coreclr/templates/xplat-job.yml: Could not retrieve file content for /eng/common/templates/job/job.yml from repository self hosted on https://github.com/ using commit df7097f3fc659c48af0cdc2886a43cd7f4fbaa07. GitHub reported the error, "Bad credentials"

https://github.com/dotnet/runtime/pull/39655/checks?check_run_id=891553015

@trylek
Copy link
Member

trylek commented Jul 21, 2020

@MattGal / @mmitche - this looks like expired certificates or some such.

@safern
Copy link
Member

safern commented Jul 21, 2020

I tried rerunning it manually and I'm getting:

No plan found for identifier aee3bf87-841d-4319-af75-e94d845e410f.

Could you try ammending the commit and force pushing?

safern
safern reviewed Jul 21, 2020
View reviewed changes
eng/pipelines/runtime-official.yml Outdated
@@ -56,7 +56,6 @@ stages:
- Linux_musl_arm64
- Windows_NT_x86
- Windows_NT_x64
- Windows_NT_arm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the official build, which means if we remove this, we will stop producing an arm runtime. Is that desired?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is desired. However we may want to be the last people to remove so the upstack components do not break.

safern
safern reviewed Jul 21, 2020
View reviewed changes
eng/pipelines/runtime-official.yml Outdated
@@ -158,7 +157,6 @@ stages:
- Linux_musl_arm64
- Windows_NT_x86
- Windows_NT_x64
- Windows_NT_arm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

safern
safern reviewed Jul 21, 2020
View reviewed changes
eng/pipelines/runtime-official.yml Outdated
@@ -199,7 +197,6 @@ stages:
- Linux_musl_arm64
- Windows_NT_x86
- Windows_NT_x64
- Windows_NT_arm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

@erozenfeld
Copy link
Member Author

@BruceForstall @jashook Do we want to remove Windows arm from official builds?

@erozenfeld
Limit arm32 Windows testing.
a3cfeb4 
Remove Windows arm32 testing from PRs. Builds are not removed.
Remove Windows arm32 jitstress testing.
Remove Windows arm32 builds from official builds.

Outerloop still has Windows arm32 builds and testing.
@erozenfeld
Copy link
Member Author

I reverted the changes to runtime-official.yml.

@MattGal
Copy link
Member

MattGal commented Jul 21, 2020

@MattGal / @mmitche - this looks like expired certificates or some such.

I was at lunch but I see builds running now, let me know if you see it again, and we can investigate.

@erozenfeld erozenfeld marked this pull request as ready for review July 22, 2020 19:36
@erozenfeld
Copy link
Member Author

@jashook @BruceForstall @safern PTAL

@erozenfeld erozenfeld requested a review from BruceForstall July 22, 2020 19:36
safern
safern approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jashook
jashook approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@jashook jashook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm the only work left is to move arm64 testing onto the arm32 queue. This can be done in another pr.

@erozenfeld erozenfeld merged commit 66a7205 into dotnet:master Jul 22, 2020
erozenfeld added a commit to erozenfeld/runtime that referenced this pull request Jul 22, 2020
@erozenfeld
Switch Windows arm64 testing to use Windows.10.Arm64v8.Open queue.
e8bc4a0 
Windows arm testing has been scaled back in dotnet#39655 so now we can start
using better machines for Windows arm64 testing. These machines were
previously used for Windows arm testing.
@erozenfeld erozenfeld mentioned this pull request Jul 22, 2020
Merged
erozenfeld added a commit that referenced this pull request Jul 23, 2020
@erozenfeld
Switch Windows arm64 testing to use Windows.10.Arm64v8.Open queue. (#…
2732907 
…39802)

Windows arm testing has been scaled back in #39655 so now we can start
using better machines for Windows arm64 testing. These machines were
previously used for Windows arm testing.
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@erozenfeld @Jacksondr5
Limit arm32 Windows testing. (dotnet#39655)
892e10d 
Remove Windows arm32 testing from PRs. Builds are not removed.
Remove Windows arm32 jitstress testing.
Remove Windows arm32 builds from official builds.

Outerloop still has Windows arm32 builds and testing.
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@erozenfeld @Jacksondr5
Switch Windows arm64 testing to use Windows.10.Arm64v8.Open queue. (d…
ecdb00f 
…otnet#39802)

Windows arm testing has been scaled back in dotnet#39655 so now we can start
using better machines for Windows arm64 testing. These machines were
previously used for Windows arm testing.
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@BruceForstall BruceForstall mentioned this pull request Sep 14, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern safern approved these changes

@jashook jashook jashook approved these changes

@BruceForstall BruceForstall Awaiting requested review from BruceForstall

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Limit arm32 windows testing
7 participants
@erozenfeld @trylek @safern @MattGal @jashook @karelz @Dotnet-GitSync-Bot