-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove trim_whitespaces from editorconfig #40884
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @ViktorHofer |
Did you find this option problematic in dotnet/runtime repo? I have not run into any of the issues mentioned in the linked comment while working in dotnet/runtime. |
Maybe there are a few files where it may be causing problem, but I would think that the benefits outweighs it. |
I don't understand why we're removing this. It's very helpful. |
@stephentoub @jkotas Thanks for reviews. But as stated in sharwell's comment:
I think if, now there aren't significant trailing whitespaces, I think it's not guaranteed that this will remain the same in future. |
We have an analyzer that fails the build if there's trailing whitespace in C# files. And end-of-line literally invisible code is practically impossible to maintain. Please point to an actual example in dotnet/runtime where it's causing a problem. |
@stephentoub Thanks for clarifying that. In that case, it would be possibly to exclude this option for markdown only? (I haven't seen an example in this repo where markdown trailing spaces are significant, but I've seen that in dotnet/docs before). Also, can I ask which analyzer is used for the trailing whitespaces in C# files? |
@stephentoub Another solution for the markdown files is to enable markdownlint with MD009 rule enabled. |
Related to dotnet/runtime#40887 and dotnet/runtime#40884
Related to dotnet/runtime#40887 and dotnet/runtime#40884 Co-authored-by: Youssef1313 <Youssef1313@users.noreply.github.com>
See dotnet/sdk#12865 (comment)