[wasm] Mark System.Threading.ThreadPool unsupported on Browser #41891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 tasks
|
Tagging subscribers to this area: @safern, @ViktorHofer |
akoeplinger
reviewed
Sep 4, 2020
| @@ -32,6 +33,7 @@ public static bool BindHandle(IntPtr osHandle) | |||
| throw new PlatformNotSupportedException(SR.Arg_PlatformNotSupported); // Replaced by ThreadPoolBoundHandle.BindHandle | |||
| } | |||
|
|
|||
| [UnsupportedOSPlatform("browser")] | |||
| public static bool BindHandle(SafeHandle osHandle) | |||
There was a problem hiding this comment.
I think this needs to be added to
as well
mdh1418
force-pushed
the
mdhwang/system_threading_threadpool_unsupported
branch
from
0b32bab to
7d07b8c
Compare
akoeplinger
approved these changes
Sep 4, 2020
mdh1418
commented
Sep 7, 2020
| @@ -32,6 +33,7 @@ public static bool BindHandle(IntPtr osHandle) | |||
| throw new PlatformNotSupportedException(SR.Arg_PlatformNotSupported); // Replaced by ThreadPoolBoundHandle.BindHandle | |||
| } | |||
|
|
|||
| [UnsupportedOSPlatform("browser")] | |||
There was a problem hiding this comment.
Since it looks like ThreadPool.BindHandle is not supported on any of mono, I wonder if it would be better to add support for UnsupportedOSPlatform("mono") or to list UnsupportedOSPlatform attribute for each mono platform for now. I believe having just UnsupportedOSPlatform("browser") would imply that this API is supported on the other mono platforms.
There was a problem hiding this comment.
I think this API is Windows specific (cc @jkotas for confirmation) and we could mark it that way. Using UnsupportedOSPlatform("mono") combination does not make sense.
There was a problem hiding this comment.
Yes, BindHandle is Windows-specific. CoreCLR implementation throws PNSE on Unix.
There was a problem hiding this comment.
@mdh1418 could you turn the attribute to [SupportedOSPlatform("windows")]
mdh1418
added a commit
to mdh1418/runtime
that referenced
this pull request
Sep 8, 2020
…t#41891) * System.Threading.ThreadPool enable platform attributes * Mark System.Threading.ThreadPool APIs unsupported on browser * System.Threading.ThreadPool Add Unsupported attribute to other ThreadPool files * Remove Unsupported attributes from BindHandle * Add windows Supported Attribute to BindHandle Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>
mdh1418
added a commit
that referenced
this pull request
Sep 9, 2020
* [wasm] Mark System.ComponentModel APIs as unsupported on Browser (#41094) * [wasm] System.ComponentModel enable platform attributes * [wasm] Mark ExtendedProtectionPolicyTypeConverter.ConvertTo as unsupported * [wasm] Mark System.ComponentModel.TypeDescriptor.CreateInstance as unsupported * [wasm] Mark System.ComponentModel.TypeDescriptionProvider.CreateInstance as unsupported * [wasm] Mark System.ComponentModel.LicenseManager.CreateWithContext as unsupported * [wasm] Mark System.ComponentModel.MaskedTextProvider.Clone as unsupported Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com> * [wasm] Mark System.Console APIs as unsupported on Browser (#41184) * [wasm] Mark System.Console APIs as unsupported on Browser * System.Console remove unsupported attribute from Console.Clear() * System.Console mark SetIn as unsupported on Browser * System.Console move UnsupportedOSPlatform attributes down to the accessor Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com> * Mark System.Diagnostics.FileVersionInfo as unsupported on Browser (#41271) Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com> * Mark System.Diagnostics.Process unsupported at assembly level (#41694) Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com> * [wasm] Mark System.IO.Compression APIs as unsupported on Browser (#41683) * [wasm] System.IO.Compression.Brotli enable platform attributes * Mark System.IO.Compression.Brotli unsupported at assembly level Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com> * [wasm] Mark System.IO.FileSystem.Watcher APIs as unsupported on Browser (#41682) * [wasm] System.IO.FileSystem.Watcher enable platform attributes * Mark System.IO.FileSystem.Watcher unsupported at assembly level Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com> * [wasm] Mark System.IO.IsolatedStorage APIs as unsupported on Browser (#41700) * [wasm] System.IO.IsolatedStorage enable platform attributes * Mark System.IO.IsolatedStorage Unsupported at assembly level Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com> * Mark some System.Net.* APIs as unsupported on Browser WASM (#40924) * [wasm] Mark System.Threading.ThreadPool unsupported on Browser (#41891) * System.Threading.ThreadPool enable platform attributes * Mark System.Threading.ThreadPool APIs unsupported on browser * System.Threading.ThreadPool Add Unsupported attribute to other ThreadPool files * Remove Unsupported attributes from BindHandle * Add windows Supported Attribute to BindHandle Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com> * Mark System.Net.WebSockets.ClientWebSocketOptions APIs as unsupported on Browser (#41963) * Mark System.Net.WebSockets.ClientWebSocketOptions APIs as unsupported on Browser * Add the attributes to non-browser version of ClientWebSocketOptions class to avoid build error * Add using * Include platform attributes * [wasm] Mark System.Net.NameResolution Unsupported at assembly level (#41985) Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com> Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com> Co-authored-by: Maxim Lipnin <v-maxlip@microsoft.com>
mdh1418
added a commit
to mdh1418/runtime
that referenced
this pull request
Sep 11, 2020
…t#41891) * System.Threading.ThreadPool enable platform attributes * Mark System.Threading.ThreadPool APIs unsupported on browser * System.Threading.ThreadPool Add Unsupported attribute to other ThreadPool files * Remove Unsupported attributes from BindHandle * Add windows Supported Attribute to BindHandle Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #41087