Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Mark System.Net.NameResolution Unsupported at assembly level #41985

Merged

Conversation

mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Sep 8, 2020

Contributes to #41087

M:System.Net.Dns.EndGetHostEntry(System.IAsyncResult),System.Net,Dns,EndGetHostEntry(IAsyncResult),0
M:System.Net.Dns.GetHostAddresses(System.String),System.Net,Dns,GetHostAddresses(String),0
"M:System.Net.Dns.BeginGetHostEntry(System.String,System.AsyncCallback,System.Object)",System.Net,Dns,"BeginGetHostEntry(String, AsyncCallback, Object)",0
M:System.Net.Dns.GetHostByAddress(System.Net.IPAddress),System.Net,Dns,GetHostByAddress(IPAddress),0
"M:System.Net.Dns.BeginGetHostAddresses(System.String,System.AsyncCallback,System.Object)",System.Net,Dns,"BeginGetHostAddresses(String, AsyncCallback, Object)",0
M:System.Net.Dns.GetHostEntryAsync(System.String),System.Net,Dns,GetHostEntryAsync(String),0
M:System.Net.Dns.Resolve(System.String),System.Net,Dns,Resolve(String),0
M:System.Net.Dns.GetHostByName(System.String),System.Net,Dns,GetHostByName(String),0
"M:System.Net.Dns.BeginGetHostEntry(System.Net.IPAddress,System.AsyncCallback,System.Object)",System.Net,Dns,"BeginGetHostEntry(IPAddress, AsyncCallback, Object)",0
M:System.Net.Dns.EndGetHostByName(System.IAsyncResult),System.Net,Dns,EndGetHostByName(IAsyncResult),0
M:System.Net.Dns.GetHostEntry(System.String),System.Net,Dns,GetHostEntry(String),0
M:System.Net.Dns.GetHostEntryAsync(System.Net.IPAddress),System.Net,Dns,GetHostEntryAsync(IPAddress),0
"M:System.Net.Dns.BeginGetHostByName(System.String,System.AsyncCallback,System.Object)",System.Net,Dns,"BeginGetHostByName(String, AsyncCallback, Object)",0
M:System.Net.Dns.EndGetHostAddresses(System.IAsyncResult),System.Net,Dns,EndGetHostAddresses(IAsyncResult),0
M:System.Net.Dns.EndResolve(System.IAsyncResult),System.Net,Dns,EndResolve(IAsyncResult),0
M:System.Net.Dns.GetHostByAddress(System.String),System.Net,Dns,GetHostByAddress(String),0
M:System.Net.Dns.GetHostEntry(System.Net.IPAddress),System.Net,Dns,GetHostEntry(IPAddress),0
"M:System.Net.Dns.BeginResolve(System.String,System.AsyncCallback,System.Object)",System.Net,Dns,"BeginResolve(String, AsyncCallback, Object)",0
M:System.Net.Dns.GetHostAddressesAsync(System.String),System.Net,Dns,GetHostAddressesAsync(String),0
M:System.Net.IPHostEntry.set_Aliases(System.String[]),System.Net,IPHostEntry,set_Aliases(String[]),0
M:System.Net.IPHostEntry.set_AddressList(System.Net.IPAddress[]),System.Net,IPHostEntry,set_AddressList(IPAddress[]),0
M:System.Net.IPHostEntry.get_Aliases,System.Net,IPHostEntry,get_Aliases(),0
M:System.Net.IPHostEntry.set_HostName(System.String),System.Net,IPHostEntry,set_HostName(String),0
M:System.Net.IPHostEntry.get_AddressList,System.Net,IPHostEntry,get_AddressList(),0
M:System.Net.IPHostEntry.#ctor,System.Net,IPHostEntry,.ctor(),0
M:System.Net.IPHostEntry.get_HostName,System.Net,IPHostEntry,get_HostName(),0

@ghost
Copy link

ghost commented Sep 8, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@mdh1418 mdh1418 merged commit 2b43b86 into dotnet:master Sep 8, 2020
@mdh1418 mdh1418 deleted the mdhwang/system_net_nameresolution_unsupported branch September 8, 2020 23:24
mdh1418 added a commit to mdh1418/runtime that referenced this pull request Sep 8, 2020
…otnet#41985)

Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>
@MaximLipnin
Copy link
Contributor

We have one exclusion in this namespace - M:System.Net.Dns.GetHostName which is mentioned in src/libraries/System.Net.NameResolution/src/ExcludeApiList.PNSE.Browser.txt and implemented in src/libraries/System.Net.NameResolution/src/System/Net/Dns.Browser.cs

Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mdh1418 added a commit that referenced this pull request Sep 9, 2020
* [wasm] Mark System.ComponentModel APIs as unsupported on Browser (#41094)

* [wasm] System.ComponentModel enable platform attributes

* [wasm] Mark ExtendedProtectionPolicyTypeConverter.ConvertTo as unsupported

* [wasm] Mark System.ComponentModel.TypeDescriptor.CreateInstance as unsupported

* [wasm] Mark System.ComponentModel.TypeDescriptionProvider.CreateInstance as unsupported

* [wasm] Mark System.ComponentModel.LicenseManager.CreateWithContext as unsupported

* [wasm] Mark System.ComponentModel.MaskedTextProvider.Clone as unsupported

Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>

* [wasm] Mark System.Console APIs as unsupported on Browser (#41184)

* [wasm] Mark System.Console APIs as unsupported on Browser

* System.Console remove unsupported attribute from Console.Clear()

* System.Console mark SetIn as unsupported on Browser

* System.Console move UnsupportedOSPlatform attributes down to the accessor

Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>

* Mark System.Diagnostics.FileVersionInfo as unsupported on Browser (#41271)

Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>

* Mark System.Diagnostics.Process unsupported at assembly level (#41694)

Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>

* [wasm] Mark System.IO.Compression APIs as unsupported on Browser (#41683)

* [wasm] System.IO.Compression.Brotli enable platform attributes

* Mark System.IO.Compression.Brotli unsupported at assembly level

Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>

* [wasm] Mark System.IO.FileSystem.Watcher APIs as unsupported on Browser (#41682)

* [wasm] System.IO.FileSystem.Watcher enable platform attributes

* Mark System.IO.FileSystem.Watcher unsupported at assembly level

Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>

* [wasm] Mark System.IO.IsolatedStorage APIs as unsupported on Browser (#41700)

* [wasm] System.IO.IsolatedStorage enable platform attributes

* Mark System.IO.IsolatedStorage Unsupported at assembly level

Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>

* Mark some System.Net.* APIs as unsupported on Browser WASM (#40924)

* [wasm] Mark System.Threading.ThreadPool unsupported on Browser (#41891)

* System.Threading.ThreadPool enable platform attributes

* Mark System.Threading.ThreadPool APIs unsupported on browser

* System.Threading.ThreadPool Add Unsupported attribute to other ThreadPool files

* Remove Unsupported attributes from BindHandle

* Add windows Supported Attribute to BindHandle

Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>

* Mark System.Net.WebSockets.ClientWebSocketOptions APIs as unsupported on Browser (#41963)

* Mark System.Net.WebSockets.ClientWebSocketOptions APIs as unsupported on Browser

* Add the attributes to non-browser version of ClientWebSocketOptions class to avoid build error

* Add using

* Include platform attributes

* [wasm] Mark System.Net.NameResolution Unsupported at assembly level (#41985)

Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>

Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>
Co-authored-by: Maxim Lipnin <v-maxlip@microsoft.com>
mdh1418 added a commit to mdh1418/runtime that referenced this pull request Sep 11, 2020
…otnet#41985)

Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
@karelz karelz added this to the 6.0.0 milestone Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Net
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants