Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable failing DNS tests on SLES #48759

Merged
merged 2 commits into from
Feb 25, 2021
Merged

Disable failing DNS tests on SLES #48759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad63966
Disable failing DNS tests on Linux
ViktorHofer Feb 25, 2021
4f20f43
Disable failing dns tests for sles only
ViktorHofer Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ public static partial class PlatformDetection
public static bool IsUbuntu1710OrHigher => IsDistroAndVersionOrHigher("ubuntu", 17, 10);
public static bool IsUbuntu1804 => IsDistroAndVersion("ubuntu", 18, 04);
public static bool IsUbuntu1810OrHigher => IsDistroAndVersionOrHigher("ubuntu", 18, 10);
public static bool IsSLES => IsDistroAndVersion("sles");
public static bool IsTizen => IsDistroAndVersion("tizen");
public static bool IsFedora => IsDistroAndVersion("fedora");

Expand Down
12 changes: 12 additions & 0 deletions src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostByNameTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,12 @@ public void DnsObsoleteGetHostByName_IPv6String_ReturnsOnlyGivenIP()
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotArm64Process))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/27622")]
public void DnsObsoleteGetHostByName_EmptyString_ReturnsHostName()
{
if (PlatformDetection.IsSLES)
{
// [ActiveIssue("https://github.com/dotnet/runtime/issues/48751")]
return;
}

IPHostEntry entry = Dns.GetHostByName("");

// DNS labels should be compared as case insensitive for ASCII characters. See RFC 4343.
Expand All @@ -115,6 +121,12 @@ public void DnsObsoleteGetHostByName_EmptyString_ReturnsHostName()
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotArm64Process), nameof(PlatformDetection.IsThreadingSupported))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/27622")]
public void DnsObsoleteBeginEndGetHostByName_EmptyString_ReturnsHostName()
{
if (PlatformDetection.IsSLES)
{
// [ActiveIssue("https://github.com/dotnet/runtime/issues/48751")]
return;
}

IPHostEntry entry = Dns.EndGetHostByName(Dns.BeginGetHostByName("", null, null));

// DNS labels should be compared as case insensitive for ASCII characters. See RFC 4343.
Expand Down
18 changes: 17 additions & 1 deletion src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostEntryTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,18 @@ public async Task Dns_GetHostEntryAsync_IPAddress_Ok()
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/1488", TestPlatforms.OSX)]

[ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNotArm64Process))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/27622")]
[InlineData("")]
[InlineData(TestSettings.LocalHost)]
public async Task Dns_GetHostEntry_HostString_Ok(string hostName)
{
if (PlatformDetection.IsSLES)
{
// [ActiveIssue("https://github.com/dotnet/runtime/issues/48751")]
return;
}

try
{
await TestGetHostEntryAsync(() => Task.FromResult(Dns.GetHostEntry(hostName)));
Expand Down Expand Up @@ -70,11 +77,20 @@ public async Task Dns_GetHostEntry_HostString_Ok(string hostName)
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/1488", TestPlatforms.OSX)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/48751", TestPlatforms.Linux)]
[ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNotArm64Process))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/27622")]
[InlineData("")]
[InlineData(TestSettings.LocalHost)]
public async Task Dns_GetHostEntryAsync_HostString_Ok(string hostName) =>
public async Task Dns_GetHostEntryAsync_HostString_Ok(string hostName)
{
if (PlatformDetection.IsSLES)
{
// [ActiveIssue("https://github.com/dotnet/runtime/issues/48751")]
return;
}

await TestGetHostEntryAsync(() => Dns.GetHostEntryAsync(hostName));
}

[Fact]
public async Task Dns_GetHostEntryAsync_IPString_Ok() =>
Expand Down