-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support DOTNET_ prefix #50507
Support DOTNET_ prefix #50507
Conversation
Add support for EnableDOTNETPrefix to disable respecting the DOTNET_ prefix.
Enable environment variable caching on non-Windows platforms.
I would not bother with this. If we find that there is a conflicting name, we should just fix it. |
Fix linux build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Should we reserve the |
@lambdageek That is an interesting split. @stephentoub, who filed the issue, thoughts? |
I would love for us to never utter "COMPlus" again 😄 If we feel we need to differentiate some values based on runtime, I could swallow having some be prefixed with CORECLR_ and some with MONO_, and then DOTNET_ for the general "applies everywhere" case. However, I worry such a split might lead to headaches over time, as settings initially only supported by one runtime shift to being supported everywhere (which we would generally hope to be the case as we further unify and smooth over differences). I also think it'd be potentially confusing for folks to learn about multiple prefixes and remember when to use which. And, there are other splits I don't necessarily want to change the prefix for, e.g. settings that only make sense on one OS and that are simply ignored on others. |
Yea I think in the long term it will be bad to have multiple flag prefixes as we continue to converge. I don't, for the record, feel that it's a particularly bad idea to shift CoreCLR over to a I'm just apprehensive bug reports like "Setting |
@lambdageek This is spot on. I am going to be writing up some official doc on these configs. The past week has been an amazing journey and this system is interesting to say the least. I am hoping the education can be as simple as "go to <URL> and read". |
crossgen2smoke failures are #50539 |
Fixes #47283
This enables support for using the
DOTNET_
prefix and is now the preferred first choice. TheCOMPlus_
is still supported but is the fallback.A new flag was created to ignore theDOTNET_
prefix in case external users have created a conflicting variable name.DOTNET_EnableDOTNETPrefix=0
COMPlus_EnableDOTNETPrefix=0