Fix default nothrow behavior for MethodIL.GetObject #50539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
commented
Apr 1, 2021
| @@ -84,7 +84,7 @@ public static ResolutionFailure GetAssemblyResolutionFailure(string simpleName) | |||
|
|
|||
| public void Throw() | |||
| { | |||
| switch(_failureType) | |||
| switch (_failureType) | |||
There was a problem hiding this comment.
This file gets compiled in NativeAOT branch with some more stylecop rules.
jkotas
commented
Apr 1, 2021
| @@ -86,7 +86,7 @@ public abstract partial class MethodIL | |||
| /// (typically a <see cref="MethodDesc"/>, <see cref="FieldDesc"/>, <see cref="TypeDesc"/>, | |||
| /// or <see cref="MethodSignature"/>). | |||
| /// </summary> | |||
| public abstract Object GetObject(int token, NotFoundBehavior notFoundBehavior = NotFoundBehavior.ReturnNull); | |||
| public abstract Object GetObject(int token, NotFoundBehavior notFoundBehavior = NotFoundBehavior.Throw); | |||
There was a problem hiding this comment.
This is inconsistent with the default for EcmaMethodIL.GetObject and with the original behavior.
stephentoub
approved these changes
Apr 1, 2021
This was referenced Apr 1, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered by failing tests in NativeAOT FI (dotnet/runtimelab#898)