Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of not found exported types #50845

Merged
merged 1 commit into from
Apr 8, 2021

Commits on Apr 7, 2021

  1. Fix handling of not found exported types

    This was missed in #50437.
    
    Wonder if we should have just introduced a new overload of GetType that returns `object`. This "return resolution failure that we then need to not forget to check" looks like a potential bug farm.
    
    ```csharp
    public MetadataType GetType(string nameSpace, string name, bool throwIfNotFound = true)
    {
        /* the obvious implementation that calls the virtual method */
    }
    
    public abstract object GetType(string nameSpace, string name, NotFoundBehavior notFoundBehavior)
    ```
    MichalStrehovsky authored Apr 7, 2021
    Configuration menu
    Copy the full SHA
    f6ec063 View commit details
    Browse the repository at this point in the history