Use adjusted parent layout size to handle a non-zero-sized class inheriting from a zero-sized class that inherits from another zero-sized class. #50861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riting from a zero-sized class that inherits from another zero-sized class. Fixes dotnet#50764
AaronRobinsonMSFT
approved these changes
Apr 7, 2021
|
I assume we are folding this into the .NET 5 servicing change? |
Are you talking about #50138 or something else? (Looks like that one got merged yesterday.) |
Sigh... yes. Do we think this needs to be included? |
|
Yeah I'll put together a minimal servicing change for this. |
|
Might be worth explicitly listing out all the scenarios we know about around this along with the previous behaviour vs. behaviour with these fixes? Especially with putting the changes in 5.0, considering we've already discovered various test gaps and things we had to re-fix. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the last fix for any of the zero-sized inheritance cases.
Fixes #50764