[release/5.0] Various fixes for layout class marshalling. #50882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zed class inheriting from a zero-sized class that inherits from another zero-sized class. Fixes handling of zero-sized parent types that have zero-sized parent types.
jkoritzinsky
added
Servicing-consider
jkoritzinsky
removed
the
Servicing-consider
This was referenced Apr 8, 2021
jkoritzinsky
changed the title
|
The partner team that encountered the issue has validated that this PR fixes all of the issues they saw. |
AaronRobinsonMSFT
approved these changes
Apr 15, 2021
jeffschwMSFT
approved these changes
Apr 15, 2021
jeffschwMSFT
added
the
Servicing-consider
leecow
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes handling of zero-sized parent types that have zero-sized parent types. Port of #50861 to 5.0. Also includes #50138 for next month's rollout.
Customer Impact
Without this change, developers have to manually marshal types that inherit from an empty type that inherits from another empty type. This was reported as an issue at #50764.
Regression?
This was a regression from .NET Core 3.1.
See #49857
Testing
Tests for the fix are in #50861, the corresponding change in main.
Risk
Low. This change brings us back to behavior in .NET Core 3.1 and is a very targeted change (only has an effect when fixing the broken case).