Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable SendRecvPollSync_TcpListener_Socket on Windows 8 #51186

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

MihaZupan
Copy link
Member

@MihaZupan MihaZupan commented Apr 13, 2021

Fixes #24444

This test is failing only on Windows 8.1 (Kusto)

cc @antonfirsov this is the test we discussed last week. The failures are always the same:

Assert.True(remote.Poll(0, SelectMode.SelectRead), "Read poll after completion should have succeeded");

@MihaZupan MihaZupan added this to the 6.0.0 milestone Apr 13, 2021
@MihaZupan MihaZupan requested a review from a team April 13, 2021 18:36
@ghost
Copy link

ghost commented Apr 13, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #50769
Fixes #1479
Fixes #24444

This test is failing only on Windows 8.1 (Kusto)

cc @antonfirsov this is the test we discussed last week. The failures are always the same:

Assert.True(remote.Poll(0, SelectMode.SelectRead), "Read poll after completion should have succeeded");

Author: MihaZupan
Assignees: -
Labels:

area-System.Net.Sockets

Milestone: 6.0.0

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fixes #50769
Fixes #1479
Fixes #24444

We should keep one of those open with a disabled-test label.

@k15tfu
Copy link
Contributor

k15tfu commented Apr 17, 2021

@MihaZupan Why did you say it fixes #50769 which is about test failures on Apple Silicon (not Windows 8)?

@ghost ghost locked as resolved and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: System.Net.Sockets.Tests.SendReceiveMemoryNativeTask / SendRecvPollSync_TcpListener_Socket
3 participants