-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test System.Net.Sockets.Tests.*.SendRecvPollSync_TcpListener_Socket(listenAt: ::1, pollBeforeOperation: True) failed in CI. #1479
Comments
@rmkerr can you please check how common is the failure? |
@karelz it's failed five times in the last two weeks. That isn't including the recent Nano failures, or a catastrophic failure that briefly caused all tests to fail on RHEL 6.9. With the failure today it's jumped up to the second most common networking failure over the last two weeks, after dotnet/corefx#29742. |
Sounds like worth deeper investigation, especially if it started failing this often recently-ish. |
This test is still failing on Windows10RS4 and Nano.
Documentation onn Poll() says:
Do you have any recommendation @davidsh what additional instrumentation should we add? |
All the tests in this file are historically flaky. You'll notice that many of them are Outerloop and yet don't contact external servers. That's because they were so unstable at the time that we moved them to Outerloop. poll() operations of sockets in Windows especially loopback can be problematic because of interesting optimizations for fastpath I/O that Windows does in the loopback adapter. Unless we want to spend a lot of time making these tests more stable, I would disable this particular test with an ActiveIssue for now. |
failed again in job: runtime-libraries-coreclr outerloop 20200909.3 failed test: System.Net.Sockets.Tests.SendReceiveApm.SendRecvPollSync_TcpListener_Socket(listenAt: ::1, pollBeforeOperation: False) net5.0-Windows_NT-Release-x64-CoreCLR_release-Windows.81.Amd64.Open Error message
|
failed again in job: runtime-libraries-coreclr outerloop 20201223.2 failed test: System.Net.Sockets.Tests.SendReceive_Sync.SendRecvPollSync_TcpListener_Socket(listenAt: 127.0.0.1, pollBeforeOperation: False) net6.0-windows-Release-x64-CoreCLR_release-(Windows.Nano.1809.Amd64.Open)windows.10.amd64.serverrs5.open@mcr.microsoft.com/dotnet-buildtools/prereqs:nanoserver-1809-helix-amd64-08e8e40-20200107182504 Error message
|
Removed |
Recent failures are happening in sync variants. |
Similar test failed in runtime-libraries-coreclr outerloop 20210401.4 Failed test:
Error message:
|
Failed again in runtime-libraries-coreclr outerloop 20210411.4 Faield test:
Error message:
|
Disabled for Windows 8 in #51186 |
Updating my ZeroSharp samples and this is getting in the way. The fix we did in dotnet/runtimelab#743 was insufficient (I want things to be debuggable in ZeroSharp).
triage: we should re-enable the test and fix it if we see failures. |
Fixed in #79145 |
Edit by @antonfirsov: recent failures seem to happen on Windows only, see #1479 (comment).
Test: System.Net.Sockets.Tests.SendReceiveMemoryNativeTask.SendRecvPollSync_TcpListener_Socket(listenAt: ::1, pollBeforeOperation: True) has failed.
MESSAGE:
Assert.Equal() Failure\nExpected: 123456\nActual: 123455
+++++++++++++++++++
STACK TRACE:
at System.Net.Sockets.Tests.SendReceive`1.SendRecvPollSync_TcpListener_Socket(IPAddress listenAt, Boolean pollBeforeOperation) in /mnt/j/workspace/dotnet_corefx/master/outerloop_netcoreapp_ubuntu16.04_debug/src/System.Net.Sockets/tests/FunctionalTests/SendReceive.cs:line 630 --- End of stack trace from previous location where exception was thrown ---
Details:
https://ci.dot.net/job/dotnet_corefx/job/master/job/outerloop_netcoreapp_ubuntu16.04_debug/403/testReport/System.Net.Sockets.Tests/SendReceiveMemoryNativeTask/SendRecvPollSync_TcpListener_Socket_listenAt____1__pollBeforeOperation__True_/
The text was updated successfully, but these errors were encountered: