Update SDK to 6.0 Preview 5 #55283

ViktorHofer · 2021-07-07T17:13:35Z

ghost · 2021-07-07T17:13:40Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Part of #55281

Author:	ViktorHofer
Assignees:	ViktorHofer
Labels:	`* NO MERGE *`, `area-Infrastructure`
Milestone:	6.0.0

eerhardt · 2021-07-13T20:05:17Z

@jkotas @LakshanF @agocke @vitek-karas - The trimming test failures on Windows appear to be a bad bug with trimmed coreclr apps.

Error

System.TypeLoadException
  HResult=0x80131522
  Message=Could not load type 'System.Runtime.InteropServices.DispatchWrapper' from assembly 'System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e'.
  Source=System.Private.CoreLib
  StackTrace:
   at System.Reflection.Emit.TypeBuilder.SetMethodIL(QCallModule , Int32 , Boolean , Byte[] , Int32 , Byte[] , Int32 , Int32 , ExceptionHandler[] , Int32 , Int32[] , Int32 )
   at System.Reflection.Emit.TypeBuilder.CreateTypeNoLock() in C:\git\runtime2\src\coreclr\System.Private.CoreLib\src\System\Reflection\Emit\TypeBuilder.cs:line 2061
   at System.Reflection.Emit.TypeBuilder.CreateTypeInfo() in C:\git\runtime2\src\coreclr\System.Private.CoreLib\src\System\Reflection\Emit\TypeBuilder.cs:line 1895
   at System.Xml.Serialization.XmlSerializationWriterILGen.GenerateEnd() in C:\git\runtime2\src\libraries\System.Private.Xml\src\System\Xml\Serialization\XmlSerializationWriterILGen.cs:line 72
   at System.Xml.Serialization.TempAssembly.GenerateRefEmitAssembly(XmlMapping[] , Type[] , String ) in C:\git\runtime2\src\libraries\System.Private.Xml\src\System\Xml\Serialization\Compilation.cs:line 498
   at System.Xml.Serialization.TempAssembly..ctor(XmlMapping[] , Type[] , String , String ) in C:\git\runtime2\src\libraries\System.Private.Xml\src\System\Xml\Serialization\Compilation.cs:line 67
   at System.Xml.Serialization.XmlSerializer.GenerateTempAssembly(XmlMapping , Type , String , String ) in C:\git\runtime2\src\libraries\System.Private.Xml\src\System\Xml\Serialization\XmlSerializer.cs:line 308
   at System.Xml.Serialization.XmlSerializer.GenerateTempAssembly(XmlMapping , Type , String ) in C:\git\runtime2\src\libraries\System.Private.Xml\src\System\Xml\Serialization\XmlSerializer.cs:line 291
   at System.Xml.Serialization.XmlSerializer..ctor(Type , String ) in C:\git\runtime2\src\libraries\System.Private.Xml\src\System\Xml\Serialization\XmlSerializer.cs:line 237
   at System.Xml.Serialization.XmlSerializer..ctor(Type ) in C:\git\runtime2\src\libraries\System.Private.Xml\src\System\Xml\Serialization\XmlSerializer.cs:line 195
   at System.Xml.Schema.XmlSchema.Write(XmlWriter writer, XmlNamespaceManager namespaceManager) in C:\git\runtime2\src\libraries\System.Private.Xml\src\System\Xml\Schema\XmlSchema.cs:line 133
   at XMLSchemaExamples.Main() in C:\git\runtime2\artifacts\bin\trimmingTests\projects\System.Private.Xml.TrimmingTests\XmlSchema.Write\win-x64\XmlSchema.Write.cs:line 51

Comparing working to non-working

In the "working" version, CoreLib contains the DispatchWrapper class. In the "non-working" version, DispatchWrapper is gone.

Change that caused it

In Preview5, we are setting more feature switches by default, specifically we are defaulting --feature System.Runtime.InteropServices.BuiltInComInterop.IsSupported false. This apparently means that IL Ref Emit no longer works on Windows when BuiltInComInterop is disabled.

I'm opening an issue for this now.

eerhardt · 2021-07-13T20:42:22Z

I've opened #55600 for the windows trimming failures. The tests caught a bug in our product.

Anipik · 2021-07-13T21:31:18Z

@eerhardt can we turn off this feature in order to unblock this pr ?

eerhardt · 2021-07-13T21:49:55Z

can we turn off this feature in order to unblock this pr ?

One quick way to do that is to set <BuiltInComInteropSupport>true</BuiltInComInteropSupport> in the trimming .csproj template here:

runtime/eng/testing/linker/project.csproj.template

Lines 14 to 18 in 14854e2

    
           <TargetingPackDir>{TargetingPackDir}</TargetingPackDir> 
        
           <NETCoreAppMaximumVersion>{NetCoreAppMaximumVersion}</NETCoreAppMaximumVersion> 
        
           <MicrosoftNETCoreAppVersion>{MicrosoftNETCoreAppVersion}</MicrosoftNETCoreAppVersion> 
        
           <_ExtraTrimmerArgs>{ExtraTrimmerArgs} $(_ExtraTrimmerArgs)</_ExtraTrimmerArgs>

agocke · 2021-07-13T21:50:26Z

Yes, this seems like a good solution to unblock the infra change.

eng/testing/linker/project.csproj.template

hoyosjs · 2021-07-16T00:13:02Z

hmm, now newtonsoft is missing?

eerhardt · 2021-07-16T02:50:32Z

The dotnet-linker-tests wasm leg is failing due to:


/__w/1/s/.dotnet/sdk/6.0.100-preview.5.21302.13/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(33,5): error NETSDK1147: To build this project, the following workloads must be installed: microsoft-net-sdk-blazorwebassembly-aot [/__w/1/s/artifacts/bin/trimmingTests/projects/Microsoft.Extensions.DependencyInjection.TrimmingTests/ActivatorUtilitiesTests/browser-wasm/project.csproj]
/__w/1/s/.dotnet/sdk/6.0.100-preview.5.21302.13/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(33,5): error NETSDK1147: To install these workloads, run the following command: dotnet workload install microsoft-net-sdk-blazorwebassembly-aot [/__w/1/s/artifacts/bin/trimmingTests/projects/Microsoft.Extensions.DependencyInjection.TrimmingTests/ActivatorUtilitiesTests/browser-wasm/project.csproj]
##[error].dotnet/sdk/6.0.100-preview.5.21302.13/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(33,5): error NETSDK1147: (NETCORE_ENGINEERING_TELEMETRY=Build) To build this project, the following workloads must be installed: microsoft-net-sdk-blazorwebassembly-aot
To install these workloads, run the following command: dotnet workload install microsoft-net-sdk-blazorwebassembly-aot

@lewing @radical @SamMonoRT - any thoughts? Why would this error start happening by upgrading the SDK from preview4 to preview5?

Looks like it isn't just the trimming tests, I see it on the other wasm legs:

https://helix.dot.net/api/2019-06-17/jobs/bb7717ef-0390-4821-b3e4-61ba0340e1d5/workitems/JIT.Generics/console

lewing · 2021-07-16T02:59:47Z

Yes. This is likely going to be tricky.

lewing · 2021-07-16T18:55:41Z

cc @radekdoulik

For in-tree builds, and tests we don't want to use workloads from dotnet being used to build these. For the projects being built on the build machine, we can disable them via `Directory.Build.props`, and wasm's InTree/LocalBuild props. But for projects that get built on helix, eg. the runtime tests, we are setting the property values as environment variables.

radical · 2021-07-17T00:10:56Z

Hopefully, this will fix the breakage.

eerhardt · 2021-07-17T04:10:05Z

@agocke @vitek-karas - the installer host model tests are now failing:

application dependencies manifest (LightupLib.deps.json) was not found:\n package: 'Newtonsoft.Json', version: '9.0.1'\n path:

eerhardt · 2021-07-18T23:47:08Z

eng/testing/linker/project.csproj.template

@@ -15,6 +15,8 @@
    <TargetingPackDir>{TargetingPackDir}</TargetingPackDir>
    <NETCoreAppMaximumVersion>{NetCoreAppMaximumVersion}</NETCoreAppMaximumVersion>
    <MicrosoftNETCoreAppVersion>{MicrosoftNETCoreAppVersion}</MicrosoftNETCoreAppVersion>
+    <!-- Workaround issue: https://github.com/dotnet/runtime/issues/55600 -->
+    <BuiltInComInteropSupport>true</BuiltInComInteropSupport>


This can be reverted now that #55756 is merged.

In preview5, the workload manifest overrides `$(UsingBrowserRuntimeWorkload)` setting, so pass it on the command line. ``xml <PropertyGroup Condition="'$(RuntimeIdentifier)' == 'browser-wasm'"> <UsingBrowserRuntimeWorkload Condition="'$(RunAOTCompilation)' == 'true' or '$(UsingMicrosoftNETSdkBlazorWebAssembly)' != 'true'" >true</UsingBrowserRuntimeWorkload> <UsingBrowserRuntimeWorkload Condition="'$(UsingBrowserRuntimeWorkload)' == ''" >$(WasmNativeWorkload)</UsingBrowserRuntimeWorkload> </PropertyGroup> ```

In P5 we don't generate .runtimeconfig.dev.json anymore. Some tests started to fail because they relied on the .runtime.dev.json to include local nuget cache in the probing paths. I changed one of those tests to force-generate .runtimeconfig.dev.json as for the tested scenario it seems to make sense. For the other test I modified it to copy the necessary dependency into the right location instead.

vitek-karas · 2021-07-19T13:35:46Z

I have a fix for the host tests here: https://github.com/vitek-karas/runtime/tree/FixHostTests.
Pushed the change to this PR as well.

…verywhere

radical · 2021-07-20T01:17:05Z

Wasm/windows:

System.Net.Http.Functional.Tests timing out when running with chrome:

ChromeDriver was started successfully.
[22:40:23] info: Loaded RemoteLoopServer.GenericHandler middleware
[22:40:23] info: Loaded NetCoreServer.GenericHandler middleware
[22:40:23] info: browser: Console websocket connected.
[22:40:23] info: Arguments: --setenv=DOTNET_TEST_WEBSOCKETHOST=127.0.0.1:49471,--setenv=DOTNET_TEST_HTTPHOST=127.0.0.1:49471,--setenv=DOTNET_TEST_REMOTE_LOOP_HOST=127.0.0.1:49471,--setenv=DOTNET_TEST_SECUREWEBSOCKETHOST=127.0.0.1:49472,--setenv=DOTNET_TEST_SECUREHTTPHOST=127.0.0.1:49472,--setenv=DOTNET_TEST_HTTP2HOST=127.0.0.1:49472,--run,WasmTestRunner.dll,System.Net.Http.Functional.Tests.dll,-notrait,category=IgnoreForCI,-notrait,category=OuterLoop,-notrait,category=failing
[22:40:29] info: Initializing.....
[22:40:32] info: Discovering: System.Net.Http.Functional.Tests.dll (method display = ClassAndMethod, method display options = None)
[22:40:32] info: Discovered:  System.Net.Http.Functional.Tests.dll (found 432 of 1542 test cases)
[22:40:32] info: Starting:    System.Net.Http.Functional.Tests.dll
[22:55:23] fail: Application has finished with exit code TIMED_OUT but 0 was expected
XHarness exit code: 71 (GENERAL_FAILURE)

@radekdoulik any idea about why this might be timing out?

System.Net.WebSockets.Client.Tests failures are [wasm] SendReceive_VaryingLengthBuffers_Success failing in CI #53957

eng/pipelines/runtime-linker-tests.yml

…ojects

Anipik · 2021-07-22T19:26:53Z

Known Failure #55999

* Update SDK to 6.0 Preview 6 Part of #55281 * Enable COM support to work around missing symbols in tests * Update eng/testing/linker/project.csproj.template * Disable the workload targets * Disable workloads for wasm builds For in-tree builds, and tests we don't want to use workloads from dotnet being used to build these. For the projects being built on the build machine, we can disable them via `Directory.Build.props`, and wasm's InTree/LocalBuild props. But for projects that get built on helix, eg. the runtime tests, we are setting the property values as environment variables. * Fix setting envvars for disabling workloads * Another attempt to fix wasm tests In preview5, the workload manifest overrides `$(UsingBrowserRuntimeWorkload)` setting, so pass it on the command line. ``xml <PropertyGroup Condition="'$(RuntimeIdentifier)' == 'browser-wasm'"> <UsingBrowserRuntimeWorkload Condition="'$(RunAOTCompilation)' == 'true' or '$(UsingMicrosoftNETSdkBlazorWebAssembly)' != 'true'" >true</UsingBrowserRuntimeWorkload> <UsingBrowserRuntimeWorkload Condition="'$(UsingBrowserRuntimeWorkload)' == ''" >$(WasmNativeWorkload)</UsingBrowserRuntimeWorkload> </PropertyGroup> ``` * Fix host tests after upgrade to P5 In P5 we don't generate .runtimeconfig.dev.json anymore. Some tests started to fail because they relied on the .runtime.dev.json to include local nuget cache in the probing paths. I changed one of those tests to force-generate .runtimeconfig.dev.json as for the tested scenario it seems to make sense. For the other test I modified it to copy the necessary dependency into the right location instead. * Fix up reflection to private FileStatus field * Disable workload resolver for wasm.build.tests, EMSDK run * Disable workloads for wasm with MSBuildEnableWorkloadResolver=false everywhere * remove linker workaround * [wasm] Remove args unnecessary for disabling workloads * Pass MSBuildEnableWorkloadResolver property to individual trimming projects Co-authored-by: Juan Sebastian Hoyos Ayala <juhoyosa@microsoft.com> Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com> Co-authored-by: Larry Ewing <lewing@microsoft.com> Co-authored-by: Ankit Jain <radical@gmail.com> Co-authored-by: vitek-karas <vitek.karas@microsoft.com> Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com> Co-authored-by: Anirudh Agnihotry <anirudhagnihotry098@gmail.com>

Update SDK to 6.0 Preview 5

0b7f3da

Part of #55281

ViktorHofer added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) area-Infrastructure labels Jul 7, 2021

ViktorHofer added this to the 6.0.0 milestone Jul 7, 2021

ViktorHofer requested a review from Anipik July 7, 2021 17:13

ViktorHofer self-assigned this Jul 7, 2021

This was referenced Jul 8, 2021

Unable to connect to the remote server error blocking clean CI #55312

Closed

Feed unreliability affecting CI #55449

Closed

Anipik removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jul 13, 2021

eerhardt mentioned this pull request Jul 15, 2021

Disable array support for the COM variant wrapper classes when built-in COM is disabled. #55756

Merged

Anipik mentioned this pull request Jul 15, 2021

Host Activation tests failing with preview 5 update #55780

Closed

Enable COM support to work around missing symbols in tests

10486e4

safern reviewed Jul 15, 2021

View reviewed changes

eng/testing/linker/project.csproj.template Outdated Show resolved Hide resolved

safern and others added 3 commits July 16, 2021 12:14

Update eng/testing/linker/project.csproj.template

177bd32

Disable the workload targets

23651a4

ViktorHofer requested a review from marek-safar as a code owner July 17, 2021 00:08

radical added 2 commits July 18, 2021 18:37

Merge remote-tracking branch 'origin/main' into ViktorHofer-patch-2

c1a69ba

Fix setting envvars for disabling workloads

807c255

eerhardt reviewed Jul 18, 2021

View reviewed changes

radical and others added 2 commits July 19, 2021 01:19

eerhardt and others added 3 commits July 19, 2021 12:10

Fix up reflection to private FileStatus field

699085f

Disable workload resolver for wasm.build.tests, EMSDK run

f18f795

Disable workloads for wasm with MSBuildEnableWorkloadResolver=false e…

06ff07c

…verywhere

karelz mentioned this pull request Jul 19, 2021

[HTTP/3] SendMoreThanStreamLimitRequests_Succeeds times out #55957

Closed

karelz mentioned this pull request Jul 20, 2021

Reenable Http2_ServerSendsInvalidSettingsValue_Error test #1581

Closed

remove linker workaround

066c97b

eerhardt reviewed Jul 21, 2021

View reviewed changes

eng/pipelines/runtime-linker-tests.yml Outdated Show resolved Hide resolved

radical added 2 commits July 21, 2021 16:50

[wasm] Remove args unnecessary for disabling workloads

43011fd

Pass MSBuildEnableWorkloadResolver property to individual trimming pr…

e14a2a7

…ojects

Anipik approved these changes Jul 22, 2021

View reviewed changes

Anipik merged commit 159a01a into main Jul 22, 2021

Anipik deleted the ViktorHofer-patch-2 branch July 22, 2021 19:27

lewing mentioned this pull request Jul 23, 2021

[release/6.0-preview7] Update dependencies from dotnet/arcade #56235

Closed

eerhardt mentioned this pull request Jul 27, 2021

[8/21 Infra rollout] update sdk to preview6 #56161

Merged

karelz mentioned this pull request Jul 28, 2021

MsQuic tests hang / long running #56487

Closed

ghost locked as resolved and limited conversation to collaborators Aug 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update SDK to 6.0 Preview 5 #55283

Update SDK to 6.0 Preview 5 #55283

ViktorHofer commented Jul 7, 2021

ghost commented Jul 7, 2021

eerhardt commented Jul 13, 2021

eerhardt commented Jul 13, 2021

Anipik commented Jul 13, 2021

eerhardt commented Jul 13, 2021

agocke commented Jul 13, 2021

hoyosjs commented Jul 16, 2021

eerhardt commented Jul 16, 2021 •

edited

Loading

lewing commented Jul 16, 2021

lewing commented Jul 16, 2021

radical commented Jul 17, 2021

eerhardt commented Jul 17, 2021

eerhardt Jul 18, 2021

vitek-karas commented Jul 19, 2021 •

edited

Loading

radical commented Jul 20, 2021

Anipik commented Jul 22, 2021

Update SDK to 6.0 Preview 5 #55283

Update SDK to 6.0 Preview 5 #55283

Conversation

ViktorHofer commented Jul 7, 2021

ghost commented Jul 7, 2021

eerhardt commented Jul 13, 2021

Error

Comparing working to non-working

Change that caused it

eerhardt commented Jul 13, 2021

Anipik commented Jul 13, 2021

eerhardt commented Jul 13, 2021

agocke commented Jul 13, 2021

hoyosjs commented Jul 16, 2021

eerhardt commented Jul 16, 2021 • edited Loading

lewing commented Jul 16, 2021

lewing commented Jul 16, 2021

radical commented Jul 17, 2021

eerhardt commented Jul 17, 2021

eerhardt Jul 18, 2021

Choose a reason for hiding this comment

vitek-karas commented Jul 19, 2021 • edited Loading

radical commented Jul 20, 2021

Anipik commented Jul 22, 2021

eerhardt commented Jul 16, 2021 •

edited

Loading

vitek-karas commented Jul 19, 2021 •

edited

Loading