-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return DSA and ECDSA keys from certificate in SignedXml. #55294
Conversation
If the X.509 certificate has a DSA or ECDSA public key, return them if they are available.
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsIf the X.509 certificate has a DSA or ECDSA public key, return them if they are available. Closes #55194 I was able to add a test case for DSA, prior to the fix the test fails with:
|
My Windows box is currently sitting in pieces behind me for a few days, so waiting to see what CI says about .NET Framework before I mark as reviewable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, provided CI agrees.
Considering the previous run was all green and the only thing that was added in the second commit is a comment, I would think the failures are unrelated. |
If the X.509 certificate has a DSA or ECDSA public key, return them if they are available.
Closes #55194
I was able to add a test case for DSA, prior to the fix the test fails with: