[debugger][wasm] Support DebuggerProxyAttribute #56872

thaystg · 2021-08-04T21:58:39Z

Implement support to DebuggerProxyAttribute
Implement support to call ToList()
Added test to ToList()

…ger_proxy_attribute * origin/main: (340 commits) add RID for Debian 11 (dotnet#56789) [wasm] [debugger] Skip thread static field (dotnet#56749) Fix timeouts in coreroot_determinism test in GC stress mode (dotnet#56770) Use File.OpenHandle in Socket.SendFile directly (dotnet#56777) accept empty realm for digest auth (dotnet#56369) (dotnet#56455) [wasm][debugger] Create test Inherited Properties (dotnet#56754) Mark new test as incompatible with GC Mark4781_1GcStressIncompatible (dotnet#56739) Ensure MetadataEnumResult is sufficiently updated by MetaDataImport::Enum (dotnet#56756) [mono] Remove gdb xdebug and binary writer support, it hasn't worked in a while. (dotnet#56759) Update windows-requirements.md (dotnet#56476) Update doc and generic parameter name for JsonValue.GetValue (dotnet#56639) [wasm][debugger] Inspect static class (dotnet#56740) Fix stack overflow handling issue in GC stress (dotnet#56733) Use ReflectionOnly as serialization mode in case dynamic code runtime feature is not supported (dotnet#56604) Move Windows Compat pack to NuGet pack task (dotnet#56686) Fix build error when building some packages (dotnet#56767) Simplify JIT shutdown logic in crossgen2 (dotnet#56687) Fix race in crossdac publishing with PGO (dotnet#56762) Add DictionaryKeyPolicy support for EnumConverter [dotnet#47765] (dotnet#54429) Use ComWrappers in some Marshal unit-tests and update platform metadata (dotnet#56595) ...

…ger_proxy_attribute * origin/main: disable token info in traces. (dotnet#56780) [debugger] Fix debugger.break behavior (dotnet#56788) [mono][wasm] Allow setting env variables with '=' characters in the test runner. (dotnet#56802) Ecma edit for `conv.ovf.<to type>.un`. (dotnet#56450) Mark HandleProcessCorruptedStateExceptionsAttribute as obsolete (dotnet#56664) Enable SxS install of previews on Mac OS (dotnet#56797) CoreCLR runtime tests + Mono on the x64 iOS simulator (dotnet#43954) [main] Update dependencies from mono/linker (dotnet#56593) STJ: Fix deserialization of UInt16 properties (dotnet#56793)

ghost · 2021-08-04T21:58:52Z

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #49912

Author:	thaystg
Assignees:	-
Labels:	`area-Debugger-mono`
Milestone:	-

ghost · 2021-08-04T21:59:49Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #49912

Author:	thaystg
Assignees:	-
Labels:	`arch-wasm`, `area-Debugger-mono`
Milestone:	-

src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs

src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs

radical · 2021-08-11T04:19:25Z

How is this related to #49912 ?

radical

Please excuse my lack of knowledge about the debugger agent/sdb etc bits :)
First read through.

src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs

src/mono/wasm/debugger/DebuggerTestSuite/CustomViewTests.cs

thaystg

How is this related to #49912 ?

I also implemented now the ToList(), I thought it was working, that is why I didn't test. And with this implementation after calling ToList() it will show a beautiful list as it's in the image in the PR description.

lewing · 2021-08-14T20:45:24Z

/azp run runtime

azure-pipelines · 2021-08-14T20:45:53Z

Azure Pipelines successfully started running 1 pipeline(s).

radical

Most of the suggestions don't have to be in this PR itself. So, reviewing this with comments. More tests would be useful too, like for DebuggerProxy stuff (eg. proxy type in different assembly).

src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs

radical · 2021-08-15T21:33:24Z

src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs

+                    var className = await proxy.SdbHelper.GetTypeNameOriginal(sessionId, typeIds[0], token);
+                    if (methodId == 0) //try to search on System.Linq.Enumerable
+                    {
+                        var linqTypeId = await proxy.SdbHelper.GetTypeByName(sessionId, "System.Linq.Enumerable", token);


This is a static class, so can we cache it?

radical · 2021-08-15T21:33:41Z

src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs

+                    {
+                        var linqTypeId = await proxy.SdbHelper.GetTypeByName(sessionId, "System.Linq.Enumerable", token);
+                        var linqInitialize = await proxy.SdbHelper.TypeInitialize(sessionId, linqTypeId, token);
+                        Console.WriteLine($"linqInitialize - {linqInitialize}");


can be dropped

src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs

radical · 2021-08-15T21:41:32Z

src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs

@@ -783,6 +857,16 @@ public async Task<string> GetAssemblyName(SessionId sessionId, int assembly_id,
            return retDebuggerCmdReader.ReadString();
        }

+        public async Task<string> GetAssemblyNameOriginal(SessionId sessionId, int assembly_id, CancellationToken token)


GetAssemblyNameOriginal, and GetAssemblyNameFull seem slightly misnamed.
Maybe, GetAssemblyNameOriginal -> GetFullAssemblyName or GetAssemblyNameFull
and GetAssemblyNameFull -> GetAssemblyFileNameFromId

radical · 2021-08-16T05:30:06Z

src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs

@@ -49,6 +50,18 @@ internal enum TokenType
        MdtBaseType             = 0x72000000,       // Leave this on the high end value. This does not correspond to metadata table
    }

+    [Flags]
+    internal enum GetObjectCommandType


Maybe rename to GetObjectCommandOptions

radical · 2021-08-16T05:30:32Z

src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs

                }
            }
            return null;
        }

-        public async Task<string> GetTypeName(SessionId sessionId, int type_id, CancellationToken token)
+        public async Task<string> GetDebuggerDisplayAttribute(SessionId sessionId, int objectId, int typeId, CancellationToken token)


rename to GetValueFromDebuggerDisplayAttribute

radical · 2021-08-16T05:31:24Z

src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs

+            return retDebuggerCmdReader.ReadInt32();
+        }
+
+        public async Task<JArray> GetDebuggerProxyAttribute(SessionId sessionId, int objectId, int typeId, CancellationToken token)


rename to GetValuesFromDebuggerProxyAttribute

radical · 2021-08-16T05:32:22Z

src/mono/wasm/debugger/BrowserDebugProxy/EvaluateExpression.cs

@@ -192,7 +192,7 @@ private object ConvertJSToCSharpType(JToken variable)
                    case "boolean":
                        return value?.Value<bool>();
                    case "object":
-                        return null;
+                        return variable;


Tests needed for this

radical · 2021-08-16T05:36:12Z

src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs

+                //reading buffer only to advance the reader to the next cattr
+                var parmCount = retDebuggerCmdReader.ReadInt32();
+                for (int j = 0; j < parmCount; j++)
+                {
+                    //to typed_args
+                    await CreateJObjectForVariableValue(sessionId, retDebuggerCmdReader, "varName", false, -1, token);
                }
-                else
+
+                parmCount = retDebuggerCmdReader.ReadInt32();
+                for (int j = 0; j < parmCount; j++)
                {
-                    var parmCount = retDebuggerCmdReader.ReadInt32();
-                    for (int j = 0; j < parmCount; j++)
-                    {
-                        //to read parameters
-                        await CreateJObjectForVariableValue(sessionId, retDebuggerCmdReader, "varName", false, -1, token);
-                    }
+                    //to named_args
+                    await CreateJObjectForVariableValue(sessionId, retDebuggerCmdReader, "varName", false, -1, token);
                }


nit: do it in a loop that runs twice? or a local method that gets called twice?

@radical

discussed with @radical

radical

I don't see any blockers here. The other suggestions can be taken up in other PRs too. Thanks for addressing the feedback! 👍

lewing · 2021-08-16T21:50:49Z

failures are #57501

…information # By dotnet-maestro[bot] (4) and others # Via GitHub * origin/main: (58 commits) Localized file check-in by OneLocBuild Task (dotnet#57384) [debugger][wasm] Support DebuggerProxyAttribute (dotnet#56872) Account for type mismatch of `FIELD_LIST` members in LSRA (dotnet#57450) Qualify `sorted_table` allocation with `nothrow` (dotnet#57467) Rename transport packages to follow convention (dotnet#57504) Generate proper DWARF reg num for ARM32 (dotnet#57443) Enable System.Linq.Queryable and disable dotnet#50712 (dotnet#57464) Mark individual tests for 51211 (dotnet#57463) Fix Length for ReadOnlySequence created out of sliced Memory owned by MemoryManager (dotnet#57479) Add JsonConverter.Write/ReadAsPropertyName APIs (dotnet#57302) Remove workaround for dotnet/sdk#19482 (dotnet#57453) Do not drain HttpContentReadStream if the connection is disposed (dotnet#57287) [mono] Fix a few corner case overflow operations (dotnet#57407) make use of ports in SPN optional (dotnet#57159) Fixed H/3 stress server after the last Kestrel change (dotnet#57356) disable a failing stress test. (dotnet#57473) Eliminate temporary byte array allocations in the static constructor of `IPAddress`. (dotnet#57397) Update dependencies from https://github.com/dotnet/emsdk build 20210815.1 (dotnet#57447) [main] Update dependencies from mono/linker (dotnet#57344) Improve serializer performance (dotnet#57327) ... # Conflicts: # src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs # src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs # src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs

thaystg added 7 commits August 3, 2021 22:15

Implementing debugger proxy

7e985d2

fix compilation

3a55e21

Implement debuggerproxy attribute.

394e3f6

Reusing code for DebuggerProxy method and DebuggerDisplay method.

79e81ff

Fix unit tests.

6c0abf2

thaystg requested review from radical, lewing, vargaz and lambdageek August 4, 2021 21:58

thaystg requested a review from marek-safar as a code owner August 4, 2021 21:58

dotnet-issue-labeler bot added the area-Debugger-mono label Aug 4, 2021

thaystg added the arch-wasm WebAssembly architecture label Aug 4, 2021

thaystg added 2 commits August 4, 2021 19:37

Fixing unit tests that uses List<T>.

19d6864

Fix unit tests that uses List.

b1a32b5

radical reviewed Aug 5, 2021

View reviewed changes

src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated Show resolved Hide resolved

Addressing @radical comments.

3091b2f

lewing reviewed Aug 6, 2021

View reviewed changes

src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs Outdated Show resolved Hide resolved

thaystg and others added 3 commits August 6, 2021 14:59

Using flags enum as suggested by @lewing.

de72265

Merge branch 'main' into thays_implement_debugger_proxy_attribute

a0a420e

Fixing merge.

31eff80

radical previously requested changes Aug 11, 2021

View reviewed changes

Addressing @radical comments.

427b1f2

thaystg commented Aug 12, 2021

View reviewed changes

lewing approved these changes Aug 15, 2021

View reviewed changes

lewing requested a review from radical August 15, 2021 21:00

radical reviewed Aug 16, 2021

View reviewed changes

radical self-requested a review August 16, 2021 05:39

Addressing @radical comments.

9d6b705

radical approved these changes Aug 16, 2021

View reviewed changes

thaystg merged commit 91673de into dotnet:main Aug 16, 2021

jaredpar mentioned this pull request Aug 17, 2021

Feed unreliability affecting CI #55449

Closed

ghost locked as resolved and limited conversation to collaborators Sep 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[debugger][wasm] Support DebuggerProxyAttribute #56872

[debugger][wasm] Support DebuggerProxyAttribute #56872

thaystg commented Aug 4, 2021 •

edited

Loading

ghost commented Aug 4, 2021

ghost commented Aug 4, 2021

radical commented Aug 11, 2021

radical left a comment

thaystg left a comment •

edited

Loading

lewing commented Aug 14, 2021

azure-pipelines bot commented Aug 14, 2021

radical left a comment

radical Aug 15, 2021

radical Aug 15, 2021

radical Aug 15, 2021

radical Aug 16, 2021

radical Aug 16, 2021

radical Aug 16, 2021

radical Aug 16, 2021

radical Aug 16, 2021

radical left a comment

lewing commented Aug 16, 2021

[debugger][wasm] Support DebuggerProxyAttribute #56872

[debugger][wasm] Support DebuggerProxyAttribute #56872

Conversation

thaystg commented Aug 4, 2021 • edited Loading

ghost commented Aug 4, 2021

ghost commented Aug 4, 2021

radical commented Aug 11, 2021

radical left a comment

Choose a reason for hiding this comment

thaystg left a comment • edited Loading

Choose a reason for hiding this comment

lewing commented Aug 14, 2021

azure-pipelines bot commented Aug 14, 2021

radical left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

radical left a comment

Choose a reason for hiding this comment

lewing commented Aug 16, 2021

thaystg commented Aug 4, 2021 •

edited

Loading

thaystg left a comment •

edited

Loading