Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.0] JIT: don't clone loops where init or limit is a cast local #57685

Merged
merged 2 commits into from
Aug 19, 2021
Merged

[release/6.0] JIT: don't clone loops where init or limit is a cast local #57685

merged 2 commits into from
Aug 19, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 18, 2021 •
edited by AndyAyersMS
Loading

Backport of #57602 to release/6.0

/cc @AndyAyersMS

Customer Impact

Already reported by one customer (in 6p7). Caused crossgen2 to fail.

Testing

Verified it fixes the customer issue, plus new tests added. No diffs in existing tests (per SPMI).

Risk

Low, this is a change to disable an optimization in an uncommon situation.

AndyAyersMS and others added 2 commits August 18, 2021 20:00
@AndyAyersMS
JIT: don't clone loops where init or limit is a cast local
5803f1e 
The loop cloner assumes all computations it introduces are compatible
with TYP_INT, so don't allow cloning when the initial or final value
are variables with incompatible types.

Fixes #57535.
@AndyAyersMS @SingleAccretion
Apply suggestions from code review
4c3e5b6 
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 18, 2021
@ghost
Copy link

ghost commented Aug 18, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #57602 to release/6.0

/cc @AndyAyersMS

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@AndyAyersMS
Copy link
Member

cc @dotnet/jit-contrib @jeffschwMSFT

I take it we're supposed to label the issue with "blocking-release" and perhaps not the PR..?

@JulieLeeMSFT JulieLeeMSFT added this to the 6.0.0 milestone Aug 18, 2021
kunalspathak
kunalspathak approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jeffschwMSFT
jeffschwMSFT approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. We can merge once we have a green ci.

Should we consider this for RC1?

@AndyAyersMS
Copy link
Member

Should we consider this for RC1?

This was reported by an internal customer on 6p7 so we should try and get it into RC1.

@AndyAyersMS
Copy link
Member

Mono -llvm failing on CSCBench arm64"

  Starting:    JIT.Performance.XUnitWrapper (parallel test collections = on, max threads = 4)
    JIT/Performance/CodeQuality/Roslyn/CscBench/CscBench.sh [FAIL]
      
      Unhandled Exception:
      System.NullReferenceException: Object reference not set to an instance of an object
         at Microsoft.CodeAnalysis.CSharp.BoundTreeWalkerWithStackGuard.Visit(BoundNode node)
         at Microsoft.CodeAnalysis.CSharp.BoundTreeWalker.VisitList[BoundStatement](ImmutableArray`1 list)
         at Microsoft.CodeAnalysis.CSharp.BoundTreeWalker.VisitBlock(BoundBlock node)
         at Microsoft.CodeAnalysis.CSharp.BoundBlock.Accept(BoundTreeVisitor visitor)
         at Microsoft.CodeAnalysis.CSharp.BoundTreeVisitor.Visit(BoundNode node)

@jeffschwMSFT jeffschwMSFT merged commit 5d0820a into release/6.0 Aug 19, 2021
@akoeplinger akoeplinger deleted the backport/pr-57602-to-release/6.0 branch August 28, 2021 22:04
@ghost ghost locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kunalspathak kunalspathak kunalspathak approved these changes

@jeffschwMSFT jeffschwMSFT jeffschwMSFT approved these changes

Assignees

@AndyAyersMS AndyAyersMS

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-release
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AndyAyersMS @jeffschwMSFT @kunalspathak @JulieLeeMSFT