Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.0] JIT: don't clone loops where init or limit is a cast local #57685

Merged
merged 2 commits into from
Aug 19, 2021
Merged

[release/6.0] JIT: don't clone loops where init or limit is a cast local #57685

merged 2 commits into from
Aug 19, 2021

Commits on Aug 18, 2021

  1. JIT: don't clone loops where init or limit is a cast local 

    The loop cloner assumes all computations it introduces are compatible
with TYP_INT, so don't allow cloning when the initial or final value
are variables with incompatible types.

Fixes #57535.
    @AndyAyersMS
    AndyAyersMS authored and github-actions committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    5803f1e View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
    @AndyAyersMS @SingleAccretion
    2 people authored and github-actions committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    4c3e5b6 View commit details
    Browse the repository at this point in the history