Run runtime tests marked as JitOptimizationSensitive on Mono. #58106
Conversation
|
Tagging subscribers to this area: @directhex Issue DetailsSeveral EventPipe tests marked as JitOptimizationSensitive and are currently skipped on Mono CI. PR enables no_tiered_compilation when running CI test runs on Mono to make sure these tests gets executed as well.
|
|
Seems to do the trick, EventPipe tests running including a new JIT test that also fails. Fix for at least one failed EventPipe tests is already included in #58099, so once that gets merge this PR can be rerun. Need to investigate why new JIT tests previously not run on Mono fails and if we should disable it as part of this PR. |
lateralusX
force-pushed
the
lateralusX/enable-jit-sensetive-test-on-mono
branch
from
30d644e
to
04f16ba
Compare
|
Down to test failures on llvmaot config but tests now runs and pass on OSX (x64), Linux (arm64) using JIT and on Linux (arm64) and OSX(x64) using interpreter. Have run diagnostic tracing and runtime counters on iOS llvmaot without issues, so failures in: runtime (Mono llvmaot Pri0 Runtime Tests Run Linux arm64 release) Could be related to build or ILLinker settings used on CI. Needs further investigation, but short term I believe its is good to get the working platforms up and running and exclude failing tests on above CI lanes and add issue to fix it in net7 timeframe. |
Have never run on Mono in the past and was enabled when enabling running JIT sensetive tests.
Building Cross Compiler will rebuild S.P.C and patching CORE_ROOT after will replace with S.P.C from Cross Compiler build instead of using the one from donwloaded product build.
lateralusX
force-pushed
the
lateralusX/enable-jit-sensetive-test-on-mono
branch
from
bf67129
to
15f2465
Compare
|
Introducing error in EventPipe to make sure we see test failures on CI. |
|
Observed expected failures in EventPipe tests, proving that tests are running as part of CI with changes in this PR. |
lateralusX
force-pushed
the
lateralusX/enable-jit-sensetive-test-on-mono
branch
from
a48bba3
to
15f2465
Compare
|
Reverted EventPipe error used to test CI failures in EventPipe tests. |
lateralusX
changed the title
|
@SamMonoRT, FYI, PR makes sure we run runtime tests marked as JIT sensitive on CI. Couple of EventPipe tests was not run on platforms we expected them to run, not capturing a regression in Mono when fixing a EventPipe failure in CoreCLR. |
ghost
locked as resolved and limited conversation to collaborators
Several EventPipe tests marked as JitOptimizationSensitive and are currently skipped on Mono CI. PR enables no_tiered_compilation when running CI test runs on Mono to make sure these tests gets executed as well.