[release/6.0] Prevent AV in processinfo2 while suspended on Mono. #58158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
#55379 only fixed CoreCLR. This commit makes similar fix in Mono as well, making sure src/tests/tracing/eventpipe/diagnosticport runtime test pass on Mono.
|
Tagging subscribers to this area: Issue DetailsBackport of #58099 to release/6.0 /cc @lateralusX Customer ImpactTestingRisk
|
Co-authored-by: Martin Costello <martin@martincostello.com>
This was referenced Aug 27, 2021
marek-safar
approved these changes
Aug 27, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #58099 to release/6.0
/cc @lateralusX
Customer Impact
Sending the new processinfo2 IPC command to a Mono runtime will crash runtime, in case where runtime have been setup to suspended on start up. Primarily used by CoreCLR profiler during start up, so not a scenario for Mono, but command could still have value and should not crash runtime if used when runtime has been suspended during start up.
Testing
There are new automated tests running on CI covering this new command, problem was that it was marked as JIT sensitive (no tiered JIT) and didn't run on Mono meaning that CoreCLR fix for this was not done on Mono and test didn't fail. #58106 looks at enabling these tests on main and could potentially be backported once done.
Risk
Low (similar fix already done on CoreCLR).