Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Allow uses of pthread_condattr_setclock on Apple and Android #58884

Closed
wants to merge 1 commit into from

Conversation

lambdageek
Copy link
Member

For Android, it seems like this was broken prior to NDK r21, but we require r21
as a minimum now.

For ios it was not available prior to ios 10, which is also our minimumm now.

Fixes #58737

For Android, it seems like this was broken prior to NDK r21, but we require r21
as a minimum now.

For ios it was not available prior to ios 10, which is also our minimumm now.
@ghost
Copy link

ghost commented Sep 9, 2021

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

Issue Details

For Android, it seems like this was broken prior to NDK r21, but we require r21
as a minimum now.

For ios it was not available prior to ios 10, which is also our minimumm now.

Fixes #58737

Author: lambdageek
Assignees: -
Labels:

area-VM-meta-mono

Milestone: -

@lambdageek
Copy link
Member Author

Actually doesn't look like apple have pthread_condattr_setclock. Why did we think that it does?

@lambdageek
Copy link
Member Author

Oh, maybe I misunderstood @akoeplinger - CLOCK_MONOTONIC is available on ios 10+, but not pthread_condattr_setclock.

#58701 (comment)

So we would want to use pthread_cond_timedwait with a CLOCK_MONOTONIC argument on Apple.

@lambdageek lambdageek marked this pull request as draft September 9, 2021 20:28
@ghost ghost closed this Oct 9, 2021
@ghost
Copy link

ghost commented Oct 9, 2021

Draft Pull Request was automatically closed for inactivity. Please let us know if you'd like to reopen it.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 9, 2021
@lambdageek lambdageek deleted the fix-gh-578737 branch March 19, 2022 16:45
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise pthread_condattr_setclock on Android
2 participants