-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise pthread_condattr_setclock on Android #58737
Comments
I think it's broken or unavailable on API level <= 20, which would roughly mean that it is available since Android 5.0. What is the minimum supported version now? |
runtime/src/mono/Directory.Build.props Line 32 in 57bfe47
|
The original pull request got reverted because it fails a GCC leg that doesn't run for this type of changes - #58744. |
I pushed this to 7.0, feel free to change back to 6.0 if you feel like it should go earlier. |
#62978 put back the previously rolled back fix for this in libSystem.Native. I believe this issue is still tracking using the API on Mono. |
@akoeplinger @lambdageek Do you think this can still make it in 7? |
Filed #73650 for the remaining iOS/macOS piece. |
See #58701 (comment)
We can likely use
pthread_condattr_setclock
on Android in NDK r21. Also our minimum supported ios version is now greater than the version that didn't support CLOCK_MONOTONIC.So we can likely change the ifdef around
BROKEN_CLOCK_SOURCE
to exclude ios and Androidruntime/src/mono/mono/utils/mono-os-mutex.h
Lines 39 to 41 in e55968b
The text was updated successfully, but these errors were encountered: