Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise pthread_condattr_setclock on Android #58737

Closed
MichalStrehovsky opened this issue Sep 6, 2021 · 7 comments · Fixed by #73489
Closed

Revise pthread_condattr_setclock on Android #58737

MichalStrehovsky opened this issue Sep 6, 2021 · 7 comments · Fixed by #73489

Comments

@MichalStrehovsky
Copy link
Member

MichalStrehovsky commented Sep 6, 2021

See #58701 (comment)


We can likely use pthread_condattr_setclock on Android in NDK r21. Also our minimum supported ios version is now greater than the version that didn't support CLOCK_MONOTONIC.

So we can likely change the ifdef around BROKEN_CLOCK_SOURCE to exclude ios and Android

#if !defined(CLOCK_MONOTONIC) || defined(HOST_DARWIN) || defined(HOST_ANDROID) || defined(HOST_WASM)
#define BROKEN_CLOCK_SOURCE
#endif

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Sep 6, 2021
@MichalStrehovsky MichalStrehovsky added this to the 6.0.0 milestone Sep 6, 2021
@marek-safar marek-safar added os-android and removed untriaged New issue has not been triaged by the area owner labels Sep 7, 2021
@filipnavara
Copy link
Member

I think it's broken or unavailable on API level <= 20, which would roughly mean that it is available since Android 5.0. What is the minimum supported version now?

@MichalStrehovsky
Copy link
Member Author

<AndroidApiVersion>21</AndroidApiVersion>

@MichalStrehovsky
Copy link
Member Author

The original pull request got reverted because it fails a GCC leg that doesn't run for this type of changes - #58744.

@lambdageek
Copy link
Member

lambdageek commented Sep 9, 2021

I pushed this to 7.0, feel free to change back to 6.0 if you feel like it should go earlier.
The actual change is trivial, but I'm not sure if we will recognize failures if it leads to problems.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Sep 9, 2021
@lambdageek lambdageek modified the milestones: 6.0.0, 7.0.0 Sep 9, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Oct 9, 2021
@MichalStrehovsky
Copy link
Member Author

#62978 put back the previously rolled back fix for this in libSystem.Native. I believe this issue is still tracking using the API on Mono.

@steveisok
Copy link
Member

@akoeplinger @lambdageek Do you think this can still make it in 7?

steveisok pushed a commit to steveisok/runtime that referenced this issue Aug 5, 2022
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 5, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 9, 2022
@akoeplinger
Copy link
Member

Filed #73650 for the remaining iOS/macOS piece.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.