Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #60340 #60863

Merged
merged 12 commits into from
Nov 1, 2021
Merged

Fix for #60340 #60863

merged 12 commits into from
Nov 1, 2021

Conversation

ilonatommy
Copy link
Member

Fix completed, tests are in progress.

@ilonatommy ilonatommy requested a review from thaystg October 26, 2021 13:49
@ghost
Copy link

ghost commented Oct 26, 2021

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix completed, tests are in progress.

Author: ilonatommy
Assignees: -
Labels:

area-Debugger-mono
Milestone: -

@radical radical added the arch-wasm WebAssembly architecture label Oct 26, 2021
@ghost
Copy link

ghost commented Oct 26, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix completed, tests are in progress.

Author: ilonatommy
Assignees: -
Labels:

arch-wasm, area-Debugger-mono
Milestone: -

@thaystg thaystg requested a review from lewing October 27, 2021 12:57
@runfoapp runfoapp bot mentioned this pull request Oct 27, 2021
Closed
@ilonatommy ilonatommy marked this pull request as ready for review November 1, 2021 11:18
thaystg
thaystg approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@thaystg thaystg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ilonatommy ilonatommy merged commit 1711db7 into dotnet:main Nov 1, 2021
@ilonatommy ilonatommy mentioned this pull request Nov 1, 2021
Closed
@ilonatommy ilonatommy deleted the ilona_fix_60340 branch November 1, 2021 15:07
@ghost ghost locked as resolved and limited conversation to collaborators Dec 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thaystg thaystg thaystg approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilonatommy @thaystg @radical