[wasm][debugger] Fix debugging blazor app after ts changes. #60873

thaystg · 2021-10-26T16:32:36Z

When running a blazor app, blazor that fills variable MONO.loaded_files. With the latest changes to typescript we were ignoring the content of variable that was set from blazor.

ghost · 2021-10-26T16:32:43Z

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

When running a blazor app, blazor that fills variable MONO.loaded_files. With the latest changes to typescript we were ignoring the content of variable that was set from blazor.

Author:	thaystg
Assignees:	-
Labels:	`area-Debugger-mono`
Milestone:	-

pavelsavara · 2021-10-26T19:55:57Z

Let's get rid of runtimeHelpers.loaded_files and use MONO.loaded_files everywhere.
I introduced runtimeHelpers.loaded_files during refactoring to decrease coupling, but it's not good change.

lewing · 2021-10-26T20:06:32Z

We can and should reexamine the file loading across everything at some point but using MONO.loaded_files makes sense for now.

pavelsavara · 2021-10-26T20:38:03Z

please initialize MONO.loaded_files to [] in exports.ts
please also delete exports.ts line 79 loaded_files: runtimeHelpers.loaded_files,

… commited.

ghost · 2021-10-27T17:32:21Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

When running a blazor app, blazor that fills variable MONO.loaded_files. With the latest changes to typescript we were ignoring the content of variable that was set from blazor.

Author:	thaystg
Assignees:	-
Labels:	`arch-wasm`, `area-Debugger-mono`
Milestone:	-

radical · 2021-10-27T17:33:39Z

[13:45:15] fail: [out of order message from the browser]: http://127.0.0.1:43471/dotnet.js 0:38312 Uncaught TypeError: Cannot read property 'trim' of undefined

Seeing this in https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-60873-merge-5cfd3d45ea58416da1/Common.Tests/1/console.b40067f3.log?sv=2019-07-07&se=2021-11-16T13%3A26%3A33Z&sr=c&sp=rl&sig=MB0zNvUuSoiguFObH90liBpMLoC281X659YLQoAEqVE%3D, and other tests.

thaystg · 2021-10-27T17:33:43Z

@lewing, can we merge? I think that the errors on CI are unrelated to my change.

radical · 2021-10-27T17:35:12Z

RuntimeTests: console.error: error in mono_load_runtime_and_bcl_args: TypeError: Cannot read property 'trim' of undefined

Wasm.Build.Tests also

thaystg · 2021-10-27T17:35:55Z

thanks @radical I'll investigate then!

pavelsavara · 2021-10-27T17:48:39Z

trim would be in mono_method_resolve or bindings_lazy_init or maybe sourcePrefix.trim() in startup

thaystg · 2021-10-28T17:11:25Z

@pavelsavara , I know that you told me to not import MONO from exports, but if I don't import I get this trim error and after this (if I workaround) I get another error when trying to use MONO.loaded_files, MONO is empty when I try to use on finalize_startup.

pavelsavara · 2021-10-29T10:29:19Z

There are 2 objects perceived as MONO.

Legacy one comes from library-dotnet.js $MONO and surfaces as 'mono' in export_to_emscripten and also as MONO in ./modules and also as globalThis.MONO
The new export MONO in exports.ts, which members are merged into one above
There was third place runtimeHelpers where loaded_files lived before this PR.

I pushed change in which

we initilize loaded_files to [] and then it's merged into legacy 'mono' during export_to_emscripten
it's still gone from runtimeHelpers

Let's see if that works in CI.

…iles - disable too agresive Terser minification Co-authored-by: Thays <thaystg@gmail.com>

pavelsavara · 2021-10-29T14:38:36Z

For anybody interested, the undefined trim issue was that the Release minification was not playing well between Terser and emcc tools.

pavelsavara · 2021-10-29T17:15:17Z

Release version of the runtime can't be debugged at the moment. It's also caused by the Terser clash.

lewing · 2021-10-29T17:47:07Z

The Release runtime is what we ship so what is the plan?

thaystg · 2021-10-29T17:49:17Z

Pavel and I investigated it all the morning for me, and he will continue working on it on monday. We will find a solution.

…this case: case "mono_wasm_fire_debugger_agent_message": case "_mono_wasm_fire_debugger_agent_message":

thaystg · 2021-10-29T21:24:46Z

I pushed another commit in this PR.
We also need to keep function names otherwise it will never enter in this case on MonoProxy.cs:

                            case "mono_wasm_fire_debugger_agent_message":
                            case "_mono_wasm_fire_debugger_agent_message":

Using this PR the debugger tests are working using runtime on release and also a Blazor app can be debugged using runtime on release.

pavelsavara · 2021-10-31T17:02:23Z

I pushed another commit in this PR. We also need to keep function names otherwise it will never enter in this case on MonoProxy.cs:
                            case "mono_wasm_fire_debugger_agent_message":
                            case "_mono_wasm_fire_debugger_agent_message":
Using this PR the debugger tests are working using runtime on release and also a Blazor app can be debugged using runtime on release.

~~That should be instead exported under INTERNAL, which would stay un-mangled anyway. All other non API methods should be mangled~~

I was wrong, this is stack walk and so the function name needs to stay un-mangled.

@thaystg

thaystg · 2021-11-01T01:57:11Z

As far as I understood you will try to find another solution for the other things, so I think you can do this change to internal together, once you do I can run the debugger-tests again and test the blazor app again.

* Fix for #60340 * Fixes element access for a constant index. * Undo changes made based on #60873, that were not intended to be commited. * Removed whitespaces. * Fixed element access by local variables, added tests for element access by object member variables. * Element access by indexing with simple object members is fixed. * Nested element access is fixed, e.g. a[a[a[0]]]. * Added tests for nested element access. Reverted an unintentional change in EvaluateSimpleMethodCallsCheckChangedValue test. * Change test name to enable running test batch on calling ".EvaluateExpressionsWithElementAccess" prefix. * Fix ElementAccessByMemberVariables that was failing after previous changes. * Removed unused namespace import. Regexes are not needed in the new approach. * Added implementatio of evaluation for multidimentional indexing.

thaystg requested a review from pavelsavara October 26, 2021 16:32

thaystg marked this pull request as ready for review October 26, 2021 16:32

dotnet-issue-labeler bot added the area-Debugger-mono label Oct 26, 2021

thaystg requested a review from marek-safar as a code owner October 26, 2021 16:32

thaystg requested review from radical and lewing October 26, 2021 17:03

lewing approved these changes Oct 26, 2021

View reviewed changes

pavelsavara approved these changes Oct 26, 2021

View reviewed changes

This was referenced Oct 26, 2021

RunContinueWithStressTestsNoState timing out in CI #2271

Closed

System.Runtime.Serialization.Xml.Tests failed #59926

Closed

ilonatommy added a commit to ilonatommy/runtime that referenced this pull request Oct 27, 2021

Undo changes made based on dotnet#60873, that were not intended to be…

e828c63

… commited.

radical added the arch-wasm WebAssembly architecture label Oct 27, 2021

lewing requested a review from pavelsavara October 28, 2021 22:15

- remove runtimeHelpers.loaded_files and repace it with MONO.loaded_f…

b25cc33

…iles - disable too agresive Terser minification Co-authored-by: Thays <thaystg@gmail.com>

pavelsavara force-pushed the thays_fix_blazor_after_ts_changes branch from 1be94aa to b25cc33 Compare October 29, 2021 14:34

pavelsavara approved these changes Oct 29, 2021

View reviewed changes

runfoapp bot mentioned this pull request Oct 29, 2021

1ES Pools often run out of space #60610

Closed

thaystg added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 29, 2021

pavelsavara and others added 2 commits October 29, 2021 21:27

even lower minification and ES level, to make sure that debugging works

880e86a

We also need to keep function names otherwise it will never enter in …

cdae0bb

…this case: case "mono_wasm_fire_debugger_agent_message": case "_mono_wasm_fire_debugger_agent_message":

more detailed terser config

a415a1a

pavelsavara merged commit a5eacee into dotnet:main Nov 1, 2021

ghost locked as resolved and limited conversation to collaborators Dec 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wasm][debugger] Fix debugging blazor app after ts changes. #60873

[wasm][debugger] Fix debugging blazor app after ts changes. #60873

thaystg commented Oct 26, 2021

ghost commented Oct 26, 2021

pavelsavara commented Oct 26, 2021

lewing commented Oct 26, 2021

pavelsavara commented Oct 26, 2021 •

edited

Loading

ghost commented Oct 27, 2021

radical commented Oct 27, 2021

thaystg commented Oct 27, 2021

radical commented Oct 27, 2021

thaystg commented Oct 27, 2021

pavelsavara commented Oct 27, 2021 •

edited

Loading

thaystg commented Oct 28, 2021

pavelsavara commented Oct 29, 2021

pavelsavara commented Oct 29, 2021

pavelsavara commented Oct 29, 2021

lewing commented Oct 29, 2021

thaystg commented Oct 29, 2021

thaystg commented Oct 29, 2021 •

edited

Loading

pavelsavara commented Oct 31, 2021 •

edited

Loading

thaystg commented Nov 1, 2021 •

edited

Loading

[wasm][debugger] Fix debugging blazor app after ts changes. #60873

[wasm][debugger] Fix debugging blazor app after ts changes. #60873

Conversation

thaystg commented Oct 26, 2021

ghost commented Oct 26, 2021

pavelsavara commented Oct 26, 2021

lewing commented Oct 26, 2021

pavelsavara commented Oct 26, 2021 • edited Loading

ghost commented Oct 27, 2021

radical commented Oct 27, 2021

thaystg commented Oct 27, 2021

radical commented Oct 27, 2021

thaystg commented Oct 27, 2021

pavelsavara commented Oct 27, 2021 • edited Loading

thaystg commented Oct 28, 2021

pavelsavara commented Oct 29, 2021

pavelsavara commented Oct 29, 2021

pavelsavara commented Oct 29, 2021

lewing commented Oct 29, 2021

thaystg commented Oct 29, 2021

thaystg commented Oct 29, 2021 • edited Loading

pavelsavara commented Oct 31, 2021 • edited Loading

thaystg commented Nov 1, 2021 • edited Loading

pavelsavara commented Oct 26, 2021 •

edited

Loading

pavelsavara commented Oct 27, 2021 •

edited

Loading

thaystg commented Oct 29, 2021 •

edited

Loading

pavelsavara commented Oct 31, 2021 •

edited

Loading

thaystg commented Nov 1, 2021 •

edited

Loading